Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix substitution of prompt_agnoster_main #114

Closed
wants to merge 1 commit into from
Closed

fix: fix substitution of prompt_agnoster_main #114

wants to merge 1 commit into from

Conversation

qoomon
Copy link

@qoomon qoomon commented Jul 31, 2019 •
edited by apjanke
Loading

alternative solution would be setopt prompt_subst

Fixes #35
Fixes #113

@qoomon
fix: fix substitution of prompt_agnoster_main
c7ef942 
alternative solution would be `setopt prompt_subst`
@qoomon qoomon mentioned this pull request Aug 7, 2019
Closed
@apjanke apjanke mentioned this pull request Jan 3, 2020
Open
@apjanke
Copy link
Collaborator

apjanke commented Jan 3, 2020

Conflicts with #60.

@apjanke apjanke added the bug label Jan 3, 2020
@belak
Copy link
Contributor

belak commented Jan 3, 2020

This should not be merged, as this will most likely add back the bug fixed in #33. #60 is the better fix, and is fairly standard across prompt themes.

@apjanke
Copy link
Collaborator

apjanke commented Jan 3, 2020

Agreed.

@qoomon qoomon closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@qoomon @apjanke @belak