fix(agent): preserve cumulative stream history after tool calls#1214
Open
Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix(agent): preserve cumulative stream history after tool calls#1214Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Alexxigang wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
Alexxigang
force-pushed
the
fix/cumulative-stream-after-tools
branch
from
ce04b44 to
e56218e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this fix
In cumulative streaming mode (
StreamOptions.builder().incremental(false)),StreamingHookused the currentReasoningChunkEvent#getAccumulated()message directly. That message is scoped to a single reasoning round, so after a tool call starts the next reasoning round, previously streamed thinking/text/tool-call content is dropped from subsequent cumulative emissions.This change keeps a stream-scoped cumulative reasoning view inside
StreamingHook, replacing in-round accumulated blocks while preserving earlier reasoning-round blocks across tool execution boundaries.Validation
mvn -pl agentscope-core '-Dtest=ReActAgentTest#testCumulativeReasoningStreamKeepsHistoryAfterToolCall+testIncrementalReasoningStreamStillEmitsDeltasAfterToolCall' test -qmvn -pl agentscope-core '-Dtest=ReActAgentTest,AgentStreamingTest' test -qmvn -pl agentscope-core spotless:check -qFixes #1211