Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
io.agentscope:agentscope-parent:pom:1.0.12-SNAPSHOT
Description
Relating to problem 1 in #1184: Need to uniformly configure HTTP proxy across all model implementations
Allow users to configure proxies via
ProxyConfigon ChatModel classes such as Anthropic, DashScope, Gemini, Ollama, OpenAI, etc., consistent with the existing Builder pattern usage.For models like DashScope that already support custom
HttpTransport, clearly define the priority betweenhttpTransport()andproxy()(custom transport takes precedence;proxy()may be ignored with a warning logged) to avoid confusion where "a proxy is set but doesn't take effect."Checklist
Add a
proxy(ProxyConfig)method (or equivalent constructor parameter) to each model's Builder, and applyproxyConfig.toJavaProxy()to the internal OkHttp / SDK client (as implemented in each file).For DashScope: Extract a
resolveTransport()method. When onlyproxy()is set, apply the proxy using a defaultOkHttpTransportwithHttpTransportConfig. If bothhttpTransport()andproxy()are set,httpTransport()takes precedence and a warning is logged. Paths such as fetching the public key for encryption should use the same resolvedHttpTransport.Add or extend unit tests for the above models to cover proxy configuration and (for DashScope) transport resolution behavior.
mvn spotless:applymvn test)