fix(stdio): enforce the response bound the gateway declares - #486
Merged
Conversation
asyncio gives a subprocess stdout stream a 64 KiB limit unless told otherwise, so readline() raised a bare ValueError well before MAX_RESPONSE_BYTES was ever consulted. An ordinary 200 KiB tool response failed as an unhandled exception inside the enclave, and the 8 MB bound was unreachable. Pass the declared bound as the stream limit and turn the over-limit case into an UpstreamUnavailable refusal that names the reason, matching how every other framing failure on this path is reported. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #485.
MAX_RESPONSE_BYTESwas unreachable.create_subprocess_execwas called without alimit=, so the child's stdout stream kept asyncio's 64 KiB default, andreadline()raises a bareValueErrorpast that. The call sits insideasync with self._lockwith notry, so it escaped uncaught.The practical effect: an ordinary 200 KiB tool response, a file read or a search result, failed as an unhandled exception inside the enclave, and the 8 MB bound the gateway advertises never applied.
Two changes:
UpstreamUnavailablerefusal that names the reason, consistent with how every other framing failure on this path is reported. The session is closed, matching the desync and mismatched-id decisions.Two tests. One sends a 200 KiB response and asserts it round-trips, which fails on the pre-fix code with a
ValueError. The other monkeypatches the bound down so the refusal path can be exercised without generating 8 MB.Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
🤖 Generated with Claude Code