fix(policy): add attestation_platform to Cedar context at evaluation time (POLICY-005) - #225
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attestation_platformin the context, so policies couldn't restrictamd-sev-snp-only access — a software-only attestation would satisfy any platform-scoped policyattestation_platform: str = "unknown"parameter toCMCPProxy.__init__()and included it in_build_cedar_context()return dict"unknown"to ensure policies that checkcontext.attestation_platform == "amd-sev-snp"fail closed by defaultFixes #162.
Test plan
pytest tests/unit/test_mcp_proxy.py— all 19 pass including 2 new POLICY-005 testspytestfull suite — no regressions