fix(session): add asyncio.Lock to guard concurrent state mutations (AUTH-002) - #217
Merged
Merged
Conversation
…UTH-002) Concurrent tool-call coroutines and session-reset requests could interleave after an await boundary, corrupting max_sensitivity or losing injection events. Added `mutation_lock: asyncio.Lock` to SessionState and wrapped update_from_inspection() in proxy.py and reset() in server.py with `async with self._session.mutation_lock`. Closes #164 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
await mcp_gateway.call_tool()completes, the asyncio scheduler can run a concurrent_session_reset()request beforeupdate_from_inspection()is called, potentially corruptingmax_sensitivityor losing injection events. Addedmutation_lock: asyncio.LocktoSessionStateand used it at both mutation sites: proxy.py Step 4 and server.py_session_reset().Test plan
test_session_state_has_mutation_lock— SessionState exposes an asyncio.Locktest_concurrent_update_and_reset_do_not_corrupt_state— 10 interleaved update/reset tasks produce valid state🤖 Generated with Claude Code