feat(tee): export the SEV-SNP ABI offset table (0.10.0) - #262
Merged
Conversation
Downstreams kept a ctypes mirror of the SNP layout partly to parse and partly to read offsets off it. cmcp uses it as an offset oracle across seven test files, so sharing parse_snp_report without sharing the table would have moved the duplication into test scaffolding rather than removing it, and offsets that disagree silently are the failure this consolidation exists to prevent. SNP_OFFSETS and SNP_REPORT_LEN are checked against the genuine Azure capture rather than against themselves. Cut as 0.10.0 in the same change: purely additive, no behaviour change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes what #260 started.
cmcp keeps a ctypes mirror of the SNP layout for two reasons: to parse, and to read offsets off (
_SnpAttestationReport.measurement.offset) across seven test files. #260 shared the parse. Sharing that alone would have left the offsets behind in test scaffolding, which is the worst place for them: offsets that quietly disagree are exactly the failure this consolidation exists to prevent, and nothing would have caught it.SNP_OFFSETSandSNP_REPORT_LENare now public and checked against the genuine Azure capture rather than against themselves.Version bump included: 0.10.0, purely additive, no behaviour change.
🤖 Generated with Claude Code