ci(codeql): exclude deterministic test-vector fixtures from analysis - #225
Merged
Conversation
The conformance vector generator (python/tests/vectors/generate.py) uses a fixed, published, non-secret seed and never writes private key material to disk, so the clear-text-storage query flags a false positive. Exclude the test-vector fixtures; production code stays fully scanned. Unblocks #199.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a CodeQL
paths-ignoreforpython/tests/vectors/**so the conformance vector generator is not scanned by the security-extended query pack.Why
The vector generator (
python/tests/vectors/generate.py) uses a fixed, documented, non-secret Ed25519 test seed (bytes 00..1f, marked never for production) and deliberately never writes private key material to disk. It publishes only the public key and key_id. Thepy/clear-text-storage-sensitive-dataquery flags this fixed test seed as a false positive.Since
pull_requestruns use the base branch workflow, this exclusion has to land onmainto clear the check on contributor PRs. It unblocks #199 (language-neutral verification conformance vectors), which is otherwise a clean, well-tested contribution held only by this false positive.Production code stays fully scanned; only the deterministic test fixtures are excluded.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com