fix: sync deprecated/retired flags with lifecycle status (#99) #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a model has lifecycle.status = \"deprecated\", the model.deprecated boolean attribute now correctly returns true. - Add retired: boolean field to Model schema - Add sync_lifecycle_flags/1 that synchronizes boolean flags with lifecycle status - Add helper functions deprecated?/1 and retired?/1 for cleaner API - Add comprehensive tests for lifecycle synchronization This maintains backwards compatibility with upstream sources that only provide the simple deprecated: true flag. Fixes #99 Co-Authored-By: Claude <[email protected]>
Enhance the lifecycle system to support flexible status values beyond the original 3-state enum. This allows for provider-specific statuses and future extensibility. Changes: - Remove enum constraint from lifecycle.status (now accepts any string) - Add convenience accessor functions: - lifecycle_status/1 - Get the lifecycle status - deprecated_at/1 - Get the deprecation date - retires_at/1 - Get the retirement date - replacement/1 - Get the replacement model ID - has_replacement?/1 - Check if there's a replacement - Update sync_lifecycle_flags to handle new known statuses: - Active-like: "beta", "experimental", "alpha" - Deprecated-like: "archived", "removed" - Unknown statuses preserve existing flags (conservative) - Add comprehensive tests for flexible status handling This maintains backwards compatibility while enabling rich lifecycle metadata through the accessor functions. Relates to #99 Co-Authored-By: Claude <[email protected]>
Remove helper methods and follow the existing pattern used by other nested fields like cost, limits, and capabilities. Users now access lifecycle data directly via model.lifecycle[:status] instead of helper functions. Changes: - Remove lifecycle helper methods (deprecated?, retired?, lifecycle_status, etc.) - Update Validate.validate_model/1 to call Model.new/2 for sync logic - Update tests to use direct map access - Keep sync_lifecycle_flags/1 which now runs during build pipeline This matches the existing pattern where complex nested fields (cost, limits, capabilities) are accessed directly without helper methods. The sync logic now properly runs during the ETL pipeline, ensuring deprecated/retired booleans are synchronized with lifecycle.status in the generated packaged JSON. Relates to #99 Co-Authored-By: Claude <[email protected]>
Contributor
Author
|
trashing this to start over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lifecycle.status = "deprecated",model.deprecatednow correctly returnstrueretired: booleanfield to Model schemadeprecated?/1andretired?/1for a cleaner APITest plan
mix llm_db.modelstask still displays lifecycle indicators correctlyManual Test
🤖 Generated with Claude Code