fix: harden async handling and stabilize tests #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced `InstanceManager.lookup/2` to verify process is alive before returning pid, preventing stale pid returns from registry. - Added try/catch blocks in `AgentServer.attach/2` and `detach/2` to gracefully handle process exit scenarios with proper error tuples. - Updated `Await` module to properly propagate timeout errors in `collect_all` and `any` functions. - Removed flaky tag from instance manager stop test after fixing underlying race condition. - Extracted log capture test to separate file for better test isolation. - Replaced `Process.sleep` with `refute_eventually` for more reliable process termination assertions. - Updated hierarchy test to accept both `:normal` and `:noproc` as valid orphan reasons. - Added Logger level configuration in observe tests to ensure consistent debug output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why
Tests were failing under non-debug log levels and on timing-sensitive races (attach/stop/drain). This isolates logging config from test expectations and removes racey timing assumptions.
Testing