Skip to content

N500/wrap exception 2 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

N500/wrap exception 2 #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32bf0ec
Wrap exception from deferred to capture the current stack trace
nerzhulart Nov 3, 2025
55743f3
Use CopyableThrowable to support stacktrace recovery
nerzhulart Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions acp/api/acp.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,15 +206,21 @@ public final class com/agentclientprotocol/common/SessionParameters {
public final fun get_meta ()Lkotlinx/serialization/json/JsonElement;
}

public final class com/agentclientprotocol/protocol/AcpExpectedError : java/lang/Exception {
public final class com/agentclientprotocol/protocol/AcpExpectedError : java/lang/Exception, kotlinx/coroutines/CopyableThrowable {
public fun <init> (Ljava/lang/String;)V
public fun createCopy ()Lcom/agentclientprotocol/protocol/AcpExpectedError;
public synthetic fun createCopy ()Ljava/lang/Throwable;
public fun getMessage ()Ljava/lang/String;
}

public final class com/agentclientprotocol/protocol/JsonRpcException : java/lang/Exception {
public final class com/agentclientprotocol/protocol/JsonRpcException : java/lang/Exception, kotlinx/coroutines/CopyableThrowable {
public fun <init> (ILjava/lang/String;Lkotlinx/serialization/json/JsonElement;)V
public synthetic fun <init> (ILjava/lang/String;Lkotlinx/serialization/json/JsonElement;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public fun createCopy ()Lcom/agentclientprotocol/protocol/JsonRpcException;
public synthetic fun createCopy ()Ljava/lang/Throwable;
public final fun getCode ()I
public final fun getData ()Lkotlinx/serialization/json/JsonElement;
public fun getMessage ()Ljava/lang/String;
}

public final class com/agentclientprotocol/protocol/Protocol : com/agentclientprotocol/protocol/RpcMethodsOperations {
Expand Down Expand Up @@ -262,10 +268,6 @@ public final class com/agentclientprotocol/protocol/Protocol_extensionsKt {
public static synthetic fun setRequestHandler$default (Lcom/agentclientprotocol/protocol/RpcMethodsOperations;Lcom/agentclientprotocol/model/AcpMethod$AcpRequestResponseMethod;Lkotlin/coroutines/CoroutineContext;Lkotlin/jvm/functions/Function2;ILjava/lang/Object;)V
}

public final class com/agentclientprotocol/protocol/RequestTimeoutException : java/lang/Exception {
public fun <init> (Ljava/lang/String;)V
}

public abstract interface class com/agentclientprotocol/protocol/RpcMethodsOperations {
public abstract fun sendNotificationRaw (Lcom/agentclientprotocol/model/AcpMethod$AcpNotificationMethod;Lkotlinx/serialization/json/JsonElement;)V
public static synthetic fun sendNotificationRaw$default (Lcom/agentclientprotocol/protocol/RpcMethodsOperations;Lcom/agentclientprotocol/model/AcpMethod$AcpNotificationMethod;Lkotlinx/serialization/json/JsonElement;ILjava/lang/Object;)V
Expand Down
17 changes: 9 additions & 8 deletions acp/src/commonMain/kotlin/com/agentclientprotocol/protocol/Protocol.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ internal value class OutgoingRequestId(val id: RequestId)
/**
* An exception that gracefully handled and passed to the counterpart.
*/
public class AcpExpectedError(message: String) : Exception(message)
@OptIn(ExperimentalCoroutinesApi::class)
public class AcpExpectedError(override val message: String) : Exception(message), CopyableThrowable<AcpExpectedError> {
override fun createCopy(): AcpExpectedError = AcpExpectedError(message).also { it.addSuppressed(this) }
}

/**
* Throws [AcpExpectedError] that gracefully handled and passed to the counterpart.
Expand All @@ -42,19 +45,17 @@ public fun acpFail(message: String): Nothing = throw AcpExpectedError(message)
public fun jsonRpcMethodNotFound(message: String): Nothing =
throw JsonRpcException(JsonRpcErrorCode.METHOD_NOT_FOUND, message)

/**
* Exception thrown when a request times out.
*/
public class RequestTimeoutException(message: String) : Exception(message)

/**
* Exception thrown for JSON-RPC protocol errors.
*/
@OptIn(ExperimentalCoroutinesApi::class)
public class JsonRpcException(
public val code: Int,
message: String,
public override val message: String,
public val data: JsonElement? = null
) : Exception(message)
) : Exception(message), CopyableThrowable<JsonRpcException> {
override fun createCopy(): JsonRpcException = JsonRpcException(code, message, data).also { it.addSuppressed(this) }
}

/**
* Exception thrown when a request is cancelled explicitly by invoking [AcpMethod.MetaMethods.CancelRequest] from the calling site
Expand Down
Loading