Skip to content

feat: preview image attachments in the chat composer #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wyx20021207-create wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −6
Open

feat: preview image attachments in the chat composer #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions components/ChatInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
type AtQueryMatch, type FileIndexEntry,
} from "@/lib/file-fuzzy";
import { FolderIcon, getFileIcon } from "./FileIcons";
import { ImagePreview } from "./ImagePreview";
import { useIsMobile } from "@/hooks/useIsMobile";
import { useI18n } from "@/hooks/useI18n";
import { useChatAppearance } from "@/hooks/useChatAppearance";
Expand Down Expand Up @@ -1620,13 +1621,16 @@ export const ChatInput = forwardRef<ChatInputHandle, Props>(function ChatInput({
<div style={{ display: "flex", gap: 6, marginBottom: 6, flexWrap: "wrap" }}>
{attachedImages.map((img, i) => (
<div key={i} style={{ position: "relative", flexShrink: 0 }}>
{/* eslint-disable-next-line @next/next/no-img-element */}
<img
src={img.previewUrl}
alt=""
style={{ width: 56, height: 56, objectFit: "cover", borderRadius: 6, border: "1px solid var(--border)", display: "block" }}
/>
<ImagePreview key={img.previewUrl} src={img.previewUrl}>
{/* eslint-disable-next-line @next/next/no-img-element */}
<img
src={img.previewUrl}
alt=""
style={{ width: 56, height: 56, objectFit: "cover", borderRadius: 6, border: "1px solid var(--border)", display: "block" }}
/>
</ImagePreview>
<button
type="button"
onClick={() => removeImage(i)}
style={{
position: "absolute", top: -4, right: -4,
Expand Down
9 changes: 9 additions & 0 deletions components/ImagePreview.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ import test from "node:test";
const source = await readFile(new URL("./ImagePreview.tsx", import.meta.url), "utf8");
const cssSource = await readFile(new URL("../app/globals.css", import.meta.url), "utf8");

test("composer attachments open in the shared preview with a separate remove button", async () => {
const inputSource = await readFile(new URL("./ChatInput.tsx", import.meta.url), "utf8");
assert.match(inputSource, /import \{ ImagePreview \} from "\.\/ImagePreview"/);
assert.match(
inputSource,
/<ImagePreview key=\{img\.previewUrl\} src=\{img\.previewUrl\}>[\s\S]*?<img[\s\S]*?src=\{img\.previewUrl\}[\s\S]*?<\/ImagePreview>\s*<button\s*type="button"\s*onClick=\{\(\) => removeImage\(i\)\}/,
);
});

test("uses a native modal dialog and restores focus to its trigger", () => {
assert.match(source, /useRef<HTMLDialogElement>\(null\)/);
assert.match(source, /dialog\.showModal\(\)/);
Expand Down