Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ refactor ] Exchange components of Relation.Binary.Definitions._Respects₂_ #2515

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Dec 9, 2024

Fixes #2471

Lots of (trivial) knock-on viscosity: PR takes the opportunity to rename/refactor proofs in (hopefully!) helpful ways.

Is this v2.x or v3.0, because breaking?

jamesmckinna and others added 4 commits December 9, 2024 10:51

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@MatthewDaggitt MatthewDaggitt added this to the v3.0 milestone Dec 10, 2024
@MatthewDaggitt
Copy link
Contributor

This is definitely v3.0 I'm afraid. Large breaking change...

Copy link
Contributor

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3.0 it might be, but here's my approval anyways.

@jamesmckinna
Copy link
Contributor Author

Will resolve the merge conflict only once CHANGELOG moves from v2.2 to v2.3... but even that is likely to be premature ;-)

jamesmckinna and others added 3 commits January 18, 2025 09:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
jamesmckinna and others added 2 commits February 11, 2025 12:55

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jamesmckinna
Copy link
Contributor Author

I'll only return to the merge conflicts after v2.3 gets released (or else we fast-forward directly to v3.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relation.Binary.Definitions._Respects₂_ seems to exchange 'left' and 'right' in its left/right projections?
4 participants