-
Notifications
You must be signed in to change notification settings - Fork 247
Merge v2.1.1 into master
#2473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge v2.1.1 into master
#2473
Changes from all commits
Commits
Show all changes
327 commits
Select commit
Hold shift + click to select a range
ec52a77
Bump stdlib and agda version in installation guide (#2027)
Saransh-cpp 55ec99d
Simplify more `Data.Product` imports to `Data.Product.Base` (#2036)
Saransh-cpp 3352d4f
Wrapping Comments & Fixing Code Delimiters (#2015)
mglst c428533
Add new pattern synonym `divides-refl` to `Data.Nat.Divisibility.Core`
jamesmckinna 996795d
Simplify more `Relation.Binary` imports (#2034)
Saransh-cpp eed1b6d
Rename and deprecate `excluded-middle` (#2026)
Saransh-cpp c27b5cc
Simplified `String` imports (#2016)
Sofia-Insa de453c3
Change `Function.Definitions` to use strict inverses (#1156)
alexarice 3aa5e3a
Proofs `take/drop/head -map-commute` added to Data.List.Properties (#…
Sofia-Insa d4627c6
Simplified `Vec` import (#2018)
Sofia-Insa a590f6e
More `Data.Product` simplifications (#2039)
Saransh-cpp 17fbc46
Added Unnormalised Rational Field Structure (#1959)
guilhermehas 10ed135
More simplifications for `Relation.Binary` imports (#2038)
Saransh-cpp 35f151a
Move just a few more things over to new Function hierarchy. (#2044)
JacquesCarette 8a59faf
Final `Data.Product` import simplifications (#2052)
Saransh-cpp 1d91f75
Added properties of Heyting Commutative Ring (#1968)
guilhermehas 61531e3
Add more properties for `xor` (#2035)
Saransh-cpp 4f692f8
Additional lemmas about lists and vectors (#2020)
amblafont b57c85b
Removed redundant `import`s from `Data.Bool.Base` (#2062)
jamesmckinna 5c23f0b
Tidying up `Data.String` (#2061)
jamesmckinna 476ca71
More `Relation.Binary` simplifications (#2053)
Saransh-cpp 6f839c8
Add `drop-drop` in `Data.List.Properties` (#2043)
Saransh-cpp da7bbde
Rename `push-function-into-if`
jamesmckinna 6a544fc
agda-stdlib-utils/AllNonAsciiChars: use List1.head instead of List.head
andreasabel 4103251
Bump resolvers in stack-{9.4.5,9.6.2}.yaml
andreasabel f60b970
Bump Haskell CI to GHC 9.8.0 and 9.4.6; allow text-2.1
andreasabel e3571a3
Rename `take-drop-id` and `take++drop` (#2069)
Saransh-cpp 9311dd9
Add `find`, `findIndex`, and `findIndices` for `Data.List` (#2042)
Saransh-cpp 9cdb0fb
Final `Relation.Binary` simplifications (#2068)
Saransh-cpp ff77df9
Spellchecked `CHANGELOG` (#2078)
jamesmckinna 85d57fc
#2075: Remove symmetry assumption from lexicographic well-foundedness…
jamesmckinna 28e0bd3
Make sure RawRing defines rawRingWithoutOne (#1967)
Taneb 0bbd30c
Direct products and minor fixes (#1909)
Akshobhya1234 d260bf0
Refine imports in `Reflection.AST` (#2072)
Saransh-cpp 842a659
Add some `_∷ʳ_` properties to `Data.Vec.Properties` (#2041)
shhyou 9698a4a
Monadic join (#2079)
jamesmckinna ad13b40
Move `≡-setoid` to `Function.Indexed.Relation.Binary.Equality` (#2047)
Saransh-cpp 3cf21ec
Making (more) arguments implicit in lexicographic ordering lemmas
jamesmckinna 1b07c4a
`WellFounded` proofs for transitive closure (#2082)
jamesmckinna fc3624c
Add properties of Vector operations `reverse`, `_++_` and `fromList` …
shhyou d95bb96
Rename `minor changes` section in CHANGELOG
jamesmckinna e417e4a
Improve implementation of `splitAt`, `take` and `drop` in `Data.List`…
JacquesCarette 1baeb09
Add a recursive view of `Fin n` (#1923)
jamesmckinna 8543116
Use new style `Function` hierarchy everywhere. (#1895)
MatthewDaggitt 4ef86f2
Fix typo and whitespace violation (#2104)
fredins 3f41852
Add Kleene Algebra morphism with composition and identity construct (…
Akshobhya1234 437f6ba
Added foldr of permutation of Commutative Monoid (#1944)
guilhermehas 670d1e8
Add `begin-irrefl` reasoning combinator (#1470)
MatthewDaggitt 52c1702
Refactor some lookup and truncation lemmas (#2101)
jamesmckinna 2589f89
Add style-guide note about local suffix (#2109)
MatthewDaggitt 824cca0
Weakened pre-conditions of grouped map lemmas (#2108)
MatthewDaggitt 29e22df
Undeprecate inspect idiom (#2107)
MatthewDaggitt 8a2550f
Add some lemmas related to renamings and substitutions (#1750)
nad 6c06895
Proof of the Binomial Theorem for `(Commutative)Semiring` [supersedes…
jamesmckinna 64686b6
Modernise `Relation.Nullary` code (#2110)
MatthewDaggitt 45cb6b4
Add new fixities (#2116)
Saransh-cpp e292334
Adds setoid export to `Algebra.Bundles.SemiringWithoutOne`
jamesmckinna a8916ba
#453: added `Dense` relations and `DenseLinearOrder` (#2111)
jamesmckinna 33cb598
Rectifies the negated equality symbol in `Data.Rational.Unnormalised.…
jamesmckinna 698dfee
Sync insert, remove, and update functionalities for `List` and `Vec` …
Saransh-cpp a2341cc
De-symmetrising `Relation.Binary.Bundles.Preorder._∼_` (#2099)
jamesmckinna 2257450
Redefines `Data.Nat.Base._≤″_` (#1948)
jamesmckinna 9b10e00
Sync `iterate` and `replicate` for `List` and `Vec` (#2051)
Saransh-cpp e5f6030
Changes explicit argument `y` to implicit in `Induction.WellFounded.W…
jamesmckinna 9a1b9c9
Re-export numeric subclass instances
MatthewDaggitt e17f477
Revert "Re-export numeric subclass instances"
MatthewDaggitt 595f4e8
Add (propositional) equational reasoning combinators for vectors (#2067)
shhyou fe803f3
Strict and non-strict transitive property names (#2089)
jamesmckinna 413aa82
Re-export numeric subclass instances (#2122)
MatthewDaggitt ba789ee
Added Irreflexivity and Asymmetry of WellFounded Relations (#2119)
jmarkakis 5ec53e6
Fix argument order of composition operators (#2121)
MatthewDaggitt 2d45ecb
Make size parameter on 'replicate' explicit (#2120)
MatthewDaggitt 9bd3b43
[fixes #2130] Moving `Properties.HeytingAlgebra` from `Relation.Binar…
jamesmckinna ae5b67e
[fixes #2127] Fixes #1930 `import` bug (#2128)
jamesmckinna 5d532cf
[fixes #1214] Add negated ordering relation symbols systematically to…
jamesmckinna c111b02
Refactoring (inversion) properties of `_<_` on `Nat`, plus consequenc…
jamesmckinna 2efd5f9
Bump CI tests to Agda-2.6.4 (#2134)
MatthewDaggitt dea8bf7
Remove `Algebra.Ordered` (#2133)
MatthewDaggitt dac1b2b
[ fix ] missing name in LICENCE file (#2139)
gallais 9a68858
Add new blocking primitives to `Reflection.TCM` (#1972)
plt-amy 3f6f36a
Change definition of `IsStrictTotalOrder` (#2137)
MatthewDaggitt 60a93de
Add _<$>_ operator for Function bundle (#2144)
MatthewDaggitt 77a394a
[ fix #2086 ] new web deployment strategy (#2147)
gallais be28108
[ admin ] fix sorting logic (#2151)
gallais 7cdd4a5
Add coincidence law to modules (#1898)
Taneb 24c05d2
Make reasoning modular by adding new `Reasoning.Syntax` module (#2152)
MatthewDaggitt 019e8ae
Fixes typos identified in #2154 (#2158)
jamesmckinna 3fe4163
tackles #2124 as regards `case_return_of_` (#2157)
jamesmckinna a3235b9
Rename preorder ~ relation reasoning combinators (#2156)
MatthewDaggitt b391a3d
Move ≡-Reasoning from Core to Properties and implement using syntax (…
MatthewDaggitt e8dcbfd
Add consistent deprecation warnings to old function hierarchy (#2163)
MatthewDaggitt daa4437
Rename symmetric reasoning combinators. Minimal set of changes (#2160)
MatthewDaggitt 9352cf5
Restore 'return' as an alias for 'pure' (#2164)
MatthewDaggitt 31880ec
[ fix #2153 ] Properly re-export specialised combinators (#2161)
gallais c00fba6
Connect `LeftInverse` with (`Split`)`Surjection` (#2054)
laMudri b7358c8
Added remaining flipped and negated relations to binary relation bund…
MatthewDaggitt c42635a
Tidy up CHANGELOG in preparation for release candidate (#2165)
MatthewDaggitt 2235536
Spellcheck CHANGELOG (#2167)
jamesmckinna d7a393e
Fixed Agda version typo in README (#2176)
jamesmckinna 5bb2a86
Fixed in deprecation warning for `<-transˡ` (#2173)
jamesmckinna cedde4c
Bump Haskell CI (original!) to latest minor GHC versions (#2187)
andreasabel d8cd956
[fixes #2175] Documentation misc. typos etc. for RC1 (#2183)
jamesmckinna 67ff824
[fixes #2178] regularise and specify/systematise, the conventions for…
jamesmckinna 3941b39
Move `T?` to `Relation.Nullary.Decidable.Core` (#2189)
MatthewDaggitt e7d8642
Make decidable versions of sublist functions the default (#2186)
MatthewDaggitt 947e300
[ fix #1743 ] move README to `doc/` directory (#2184)
gallais d198697
documentation: fix link to `installation-guide`, `README.agda`, `READ…
jamesmckinna 792a838
easy deprecation; leftover from `v1.6` perhaps? (#2203)
jamesmckinna fd3cac8
fix Connex comment (#2204)
Jesin 586bca1
Add `Function.Consequences.Setoid` (#2191)
MatthewDaggitt 4220f83
Deprecating `Relation.Binary.PropositionalEquality.isPropositional` (…
jamesmckinna 37b8676
definition of `Irreducible` and `Rough`; refactoring of `Prime` and `…
jamesmckinna b58f923
[fixes #2168] Change names in `Algebra.Consequences.*` to reflect `st…
jamesmckinna 86f43fe
Add biased versions of Function structures (#2210)
MatthewDaggitt 56ed8fe
Fixes #2166 by fixing names in `IsSemilattice` (#2211)
MatthewDaggitt 67afe7c
remove final references to `Category.*` (#2214)
jamesmckinna b6ac7e0
Fix #2195 by removing redundant zero from IsRing (#2209)
MatthewDaggitt 47b458c
Fix #2216 by making divisibility definitions records (#2217)
MatthewDaggitt 39cfbcf
Fix deprecated modules (#2224)
alexarice 24370a3
Final admin changes for v2.0 release (#2225)
MatthewDaggitt 94abfa5
Fix typo in raise deprecation message (#2226)
alexarice 73ff496
Setup for v2.1 (#2227)
MatthewDaggitt 40175aa
Added tabulate+< (#2190)
guilhermehas f5f9727
Added pointwise and catmaybe in Lists (#2222)
guilhermehas c649694
[fixes #1711] Refactoring `Data.Nat.Divisibility` and `Data.Nat.DivMo…
jamesmckinna 52926d4
[fixes #2232] (#2233)
jamesmckinna d80dfdb
Add `map` to `Data.String.Base` (#2208)
lemastero f940cae
fixes issue #2237 (#2238)
jamesmckinna e7d71a3
Bring back a convenient short-cut for infix Func (#2239)
JacquesCarette d3521b6
fixes #2234 (#2241)
jamesmckinna e362f5c
Update `HACKING` (#2242)
jamesmckinna cc10e33
Bring back shortcut [fix CHANGELOG] (#2246)
JacquesCarette a05ca4a
fix toList-replicate's statement about vectors (#2261)
amblafont 6c44d20
Remove all external use of `less-than-or-equal` beyond `Data.Nat.*` (…
jamesmckinna 63b61c6
Raw modules bundles (#2263)
Taneb 64e2ba0
Parametrize module morphisms by raw bundles (#2265)
Taneb e76e213
add lemma (#2271)
jamesmckinna 98a6a8c
additions to `style-guide` (#2270)
jamesmckinna 654a7a9
fixes issue #1688 (#2254)
jamesmckinna 7c7c030
Systematise relational definitions at all arities (#2259)
jamesmckinna 709da18
lemmas about semiring structure induced by `_× x` (#2272)
jamesmckinna 07988c0
Qualified import of `Data.Nat` fixing #2280 (#2281)
jamesmckinna 04cc05c
Fix import in README.Data.Fin.Substitution.UntypedLambda (#2279)
andreasabel 8e35057
Qualified import of reasoning modules fixing #2280 (#2282)
jamesmckinna 95023d5
Qualified import of `Data.Product.Base` fixing #2280 (#2284)
jamesmckinna 95184f1
standardise use of `Properties` modules (#2283)
jamesmckinna f5cfcc7
missing code endquote (#2286)
jamesmckinna 8931b96
manual fix for #1380 (#2285)
jamesmckinna 685c213
fixed `sized-types` error in orphan module (#2295)
jamesmckinna 68b17e0
Qualified import of `PropositionalEquality` etc. fixing #2280 (#2293)
jamesmckinna 3146ae5
Added functional vector permutation (#2066)
guilhermehas bb7b51b
Nagata's "idealization of a module" construction (#2244)
jamesmckinna aebf296
Qualified import of `Data.Sum.Base` fixing #2280 (#2290)
jamesmckinna b601831
[ new ] associativity of Appending (#2023)
laMudri 6c925fa
[ new ] symmetric core of a binary relation (#2071)
laMudri 08a89c7
refactored proofs from #2023 (#2301)
jamesmckinna 07da788
Qualified imports in `Data.Integer.Divisibility` fixing #2280 (#2294)
jamesmckinna ed8d28d
guideline for `-Reasoning` module imports (#2309)
jamesmckinna ce23ff5
Function setoid is back. (#2240)
JacquesCarette ebbe65d
Style guide: avoid `renaming` on qualified import cf. #2294 (#2308)
jamesmckinna 163b7e6
make `mkRawMonad` and `mkRawApplicative` universe-polymorphic (#2314)
gshen42 242546b
Some properties of upTo and downFrom (#2316)
Taneb 2f5d88d
Tidy up `README` imports #2280 (#2313)
jamesmckinna 4529e73
Add unique morphisms from/to `Initial` and `Terminal` algebras (#2296)
jamesmckinna dd5d382
Setoid version of indexed containers. (#1511)
andreasabel 5680458
'No infinite descent' for (`Acc`essible elements of) `WellFounded` re…
jamesmckinna 9a4453e
Add new operations (cf. `RawQuasigroup`) to `IsGroup` (#2251)
jamesmckinna 6dcfbdd
Add prime factorization and its properties (#1969)
Taneb 3305541
Refactor `Data.List.Relation.Binary.BagAndSetEquality` (#2321)
jamesmckinna 0c7a3d7
Tidy up functional vector permutation #2066 (#2312)
jamesmckinna d8158c0
A tweak for the cong! tactic (#2310)
uncle-betty 204b2b2
Simplify `Data.List.Relation.Unary.Any.Properties`: remove dependency…
jamesmckinna 5989a60
Refactor `Data.Integer.Divisibility.Signed` (#2307)
jamesmckinna 014a069
Sublists: generalize disjoint-union-is-cospan to upper-bound-is-cospa…
andreasabel 2055bb3
Include CHANGELOG in fix-whitespace and whitespace fixes (#2325)
MatthewDaggitt ec51abf
Fix standard-library.agda-lib (#2326)
andreasabel 662cc67
Predicate transformers: Reconciling `Induction.RecStruct` with `Relat…
jamesmckinna 16ff145
Github action to check for whitespace violations (#2328)
andreasabel 6d51975
[refactor] Relation.Nulllary.Decidable.Core (#2329)
JacquesCarette ddb420f
Some design documentation (here: level polymorphism) (#2322)
JacquesCarette b4c78e2
mark variables private in Data.Container.FreeMonad (#2332)
cspollard e31b6c7
Move pointwise equality to `.Core` module (#2335)
JacquesCarette 5d687f7
fix warning: it was pointing to a record that did not exist. (#2344)
JacquesCarette 5cc487e
Tighten imports some more (#2343)
JacquesCarette 03a2d71
Tighten imports (#2334)
JacquesCarette b7bc4f7
[fixes #2273] Add `SuccessorSet` and associated boilerplate (#2277)
jamesmckinna ab9e0e4
Tighten imports, last big versoin (#2347)
JacquesCarette 7820c3b
Systematise use of `Relation.Binary.Definitions.DecidableEquality` (#…
jamesmckinna eafe34e
Added missing v1.7.3 CHANGELOG (#2356)
MatthewDaggitt 1d0231b
Improve `Data.List.Base.mapMaybe` (#2359; deprecate use of `with` #21…
jamesmckinna 01e20a8
Add a consequence of definition straight to IsCancellativeCommutative…
JacquesCarette 22de3ef
[ new ] System.Random bindings (#2368)
gallais d6ea9bc
Another tweak to cong! (#2340)
uncle-betty 9148fa5
Improve `Data.List.Base.unfold` (#2359; deprecate use of `with` #2123…
jamesmckinna e54ffec
fix #2253 (#2357)
jamesmckinna 05c938c
Remove uses of `Data.Nat.Solver` from a number of places (#2337)
JacquesCarette 1442ee7
Relation.Binary.PropositionalEquality over-use, (#2345)
JacquesCarette c234c72
[ new ] IO buffering, and loops (#2367)
gallais 7199c18
[ cleanup ] imports in the Effect.Monad modules (#2371)
gallais ef2bcb8
Add proofs to Data.List.Properties (#2355)
mildsunrise aad1d19
Improve `Data.List.Base` (fix #2359; deprecate use of `with` #2123) (…
jamesmckinna fd82f5c
A number of `with` are not really needed (#2363)
JacquesCarette 3d54042
[ new ] ⁻¹-anti-homo-(// | \\) (#2349)
gallais 618d838
Add `_>>_` for `IO.Primitive.Core` (#2374)
ncfavier 5515a8c
refactored to lift out `isEquivalence` (#2382)
jamesmckinna b378d4b
`Data.List.Base.reverse` is self adjoint wrt `Data.List.Relation.Bina…
jamesmckinna 507fcf8
fixes #2375 (#2377)
jamesmckinna 85d1a6b
Add `Data.List.Relation.Binary.Sublist.Setoid` categorical properties…
jamesmckinna c5538a8
Pointwise `Algebra` (#2381)
jamesmckinna 8373463
Algebra fixity (#2386)
JacquesCarette 2ac71e5
Decidable Setoid -> Apartness Relation and Rational Heyting Field (#2…
cspollard db84b73
CI bumps: ghc 9.10, action versions, Agda to 2.6.4.3 (#2398)
andreasabel c8a11e7
Refactor `Data.List.Base.scan*` and their properties (#2395)
jamesmckinna aef9afc
fixes #2390 (#2392)
jamesmckinna d992900
Add the `Setoid`-based `Monoid` on `(List, [], _++_)` (#2393)
jamesmckinna 10fd6b9
Lists: decidability of Subset+Disjoint relations (#2399)
omelkonian 30ef471
fixes #906 (#2401)
jamesmckinna 4749905
More list properties about `catMaybes/mapMaybe` (#2389)
omelkonian d06c432
Very dependent map (#2373)
JacquesCarette 9ac0bd3
Improve `Data.List.Base` (fix #2359; deprecate use of with #2123) (#2…
jamesmckinna 4018fef
Adds `Relation.Nullary.Recomputable` plus consequences (#2243)
jamesmckinna 891d50f
Refactor `List.Membership.*` and `List.Relation.Unary.Any` (#2324)
jamesmckinna e89fa26
Port two Endomorphism submodules over to new Function hierarchy (#2342)
JacquesCarette fd903e3
Add `IsIdempotentMonoid` and `IsCommutativeBand` to `Algebra.Structur…
jamesmckinna ccd432d
[ new ] Word8, Bytestring, Bytestring builder (#2376)
gallais 25b3e87
Update LICENSE (#2409)
lexvanderstoep bf7c745
Remove (almost!) all external use of `_≤″_` beyond `Data.Nat.*` (#2262)
jamesmckinna 3908d7c
Refactor `Data.Sum.{to|from}Dec` via move+deprecate in `Relation.Null…
jamesmckinna f89b415
Implement move-via-deprecate of `decToMaybe` as per #2330 (#2336)
JacquesCarette 14fc211
fixes #2411 (#2413)
jamesmckinna 949e065
Tidy up CHANGELOG in preparation for v2.1 release candidate (#2412)
MatthewDaggitt 5a4482e
[v2.1-rc1] fixes #2400: use explicit quantification instead (#2429)
jamesmckinna 0c755fc
Revert "Improve `Data.List.Base` (fix #2359; deprecate use of `with` …
jamesmckinna 1071dc5
implicit to explicit in `liftRel` (#2433)
jamesmckinna c1a9841
fix changelog (#2435)
mildsunrise ec69137
Export missing IsDecEquivalence instance for Quantity from Reflection…
jespercockx 586f56a
Add missing `showQuantity` function to Reflection.AST.Show
jespercockx c7d65e0
Compatibility with Agda PR #7322: add quantity to reflected syntax of…
jespercockx 96d4477
Bump CI for experimental to latest Agda master
andreasabel 97bc55e
Final admin changes
MatthewDaggitt 6803933
Prepare for v2.1.1 release
MatthewDaggitt dd7c481
Added v2.1.1 CHANGELOG entry
MatthewDaggitt 3e5861c
Fix #2462 by removing duplicate infix definition
MatthewDaggitt 039e1f4
Updated remaining documentation for v2.1.1 release
MatthewDaggitt 831125c
Merge in v2.1.1 and update to Agda 2.7.0
MatthewDaggitt 8403215
Update CHANGELOG.md typo
MatthewDaggitt 7ed0b35
Update CHANGELOG.md
MatthewDaggitt 561f5b9
Update installation-guide.md
MatthewDaggitt b70e3b8
Update src/Reflection/AST/Definition.agda
jamesmckinna 759b844
Update CITATION.cff
jamesmckinna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Version 2.1.1 | ||
============= | ||
|
||
The library has been tested using Agda 2.7.0. | ||
|
||
* Fixed `Reflection.AST.Definition` to take into account Agda now exposes a `Quantity` argument on the reflection `constructor` constructor. | ||
jamesmckinna marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
* In `Reflection.AST.Show` added new function `showQuantity` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't verified that these are the correct commit hashes!
(But, for info: how could/should I, were I to want to?)