fix(langgraph): regenerate first assistant response#2114
Open
prajvalrasik wants to merge 1 commit into
Open
Conversation
Author
|
Hi maintainers, just checking in on this PR when you get a chance. This fixes the first-assistant-message regenerate case from #2109 and keeps the existing user-only/SSE-drop recovery behavior unchanged. Local LangGraph integration tests pass. Happy to adjust if you want the detection handled differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2109.
Regenerating the first assistant response can send the same number of messages as the checkpoint:
Because the message counts are equal, the existing count-based regenerate heuristic is skipped and
prepare_regenerate_stream()is never reached.This change detects the explicit empty assistant placeholder case and routes regeneration from the preceding checkpointed user message.
Notes
I kept the
user onlypath unchanged because it overlaps with the existing SSE-drop recovery behavior where the client can be behind the checkpoint. This PR handles the unambiguous placeholder signal.Tests
Result: