Skip to content

Add automatic durable memory review - #12

Merged
afurm merged 1 commit into
mainfrom
af/automatic-memory-review
May 5, 2026
Merged

Add automatic durable memory review#12
afurm merged 1 commit into
mainfrom
af/automatic-memory-review

Conversation

@afurm

@afurm afurm commented May 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Problem: Draftmora only handled explicit remember-style prompts, so durable memory could miss useful stable facts from normal chat or completed task execution, and agents could imply memory was saved before it actually existed.
  • Why it matters: The local memory files are part of Draftmora's core workflow, so chat and task agents need consistent, fail-open memory review without saving secrets or short-term instructions.
  • What changed: Added a shared durable-memory review pass that uses the selected provider/model, applies reviewer-approved additions and removals to USER.md or MEMORY.md, filters secret-shaped content, injects recalled memory into chat and task execution, and runs after successful task execution.
  • What did not change: The memory files remain local plain-text USER.md and MEMORY.md entries separated by §; no new memory page, database schema, provider setting, or separate memory model was added.

Change Type

  • Bug fix
  • Feature
  • Security hardening
  • Documentation
  • Chore / infrastructure

Security Impact

  • New permissions or capabilities? No
  • Secrets or token handling changed? Yes
  • New or changed network calls? Yes
  • Local storage or memory scope changed? Yes
  • If any answer is Yes, explain the risk and mitigation: The memory review uses the already-selected provider/model and adds one provider completion call around chat or successful task execution. Reviewer output is parsed strictly, fail-open on invalid output, deduped before writing, and filtered for secret-shaped values before saving or rendering recalled memory.

Verification

  • npm audit
  • npm run typecheck
  • npm test
  • npm run build
  • npm pack --dry-run
  • UI screenshot or recording attached, if UI changed

Notes

  • Linked issue: None
  • Platform tested: macOS, Node via local npm scripts
  • Known limitations: Memory review depends on the selected provider being configured; invalid reviewer output is skipped and logged instead of blocking chat or task execution.

@afurm
afurm marked this pull request as ready for review May 5, 2026 14:57
@afurm
afurm merged commit 1a97597 into main May 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant