Skip to content

fix(install): prefix language-specific rules in manual install docs (rebased #651) #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
affaan-m wants to merge 3 commits into from
Closed

fix(install): prefix language-specific rules in manual install docs (rebased #651) #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be4663c
fix(install): prefix language-specific rules to prevent overwriting c…
tonymfer Mar 19, 2026
2e24c6c
fix: add -r flag, quote $ECC_ROOT, and guard empty globs in copy comm…
tonymfer Mar 19, 2026
6a76c1e
fix: sync catalog counts (27 agents, 113 skills, 58 commands)
affaan-m Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Everything Claude Code (ECC) — Agent Instructions

This is a **production-ready AI coding plugin** providing 27 specialized agents, 114 skills, 59 commands, and automated hook workflows for software development.
This is a **production-ready AI coding plugin** providing 27 specialized agents, 113 skills, 58 commands, and automated hook workflows for software development.

**Version:** 1.9.0

Expand Down Expand Up @@ -142,8 +142,8 @@ Troubleshoot failures: check test isolation → verify mocks → fix implementat

```
agents/ — 27 specialized subagents
skills/ — 114 workflow skills and domain knowledge
commands/ — 59 slash commands
skills/ — 109 workflow skills and domain knowledge
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistent skill count with line 3.

Line 3 declares "113 skills" but this line shows "109 workflow skills". According to the PR objectives, the target is 113 skills across the catalog.

📊 Proposed fix 
-skills/          — 109 workflow skills and domain knowledge
+skills/          — 113 workflow skills and domain knowledge
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
skills/ — 109 workflow skills and domain knowledge
skills/ — 113 workflow skills and domain knowledge
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@AGENTS.md` at line 145, The skill count is inconsistent: update the "skills/ 
— 109 workflow skills and domain knowledge" entry to reflect the correct total
of 113 skills so it matches the header (line 3) and PR objectives; locate the
string "skills/  — 109 workflow skills and domain knowledge" and change the
numeric value to 113 and verify any other summary lines referencing total skills
are consistent.

commands/ — 58 slash commands
hooks/ — Trigger-based automations
rules/ — Always-follow guidelines (common + per-language)
scripts/ — Cross-platform Node.js utilities
Expand Down
9 changes: 5 additions & 4 deletions docs/ja-JP/skills/configure-ecc/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,11 @@ Options:
# 共通ルール（rules/ にフラットコピー）
cp -r $ECC_ROOT/rules/common/* $TARGET/rules/

# 言語固有のルール（rules/ にフラットコピー）
cp -r $ECC_ROOT/rules/typescript/* $TARGET/rules/ # 選択された場合
cp -r $ECC_ROOT/rules/python/* $TARGET/rules/ # 選択された場合
cp -r $ECC_ROOT/rules/golang/* $TARGET/rules/ # 選択された場合
# 言語固有のルール（共通ルールの上書きを防ぐためプレフィックス付き）
# coding-style.md は typescript-coding-style.md のようになります
for f in "$ECC_ROOT"/rules/typescript/*; do [ -e "$f" ] && cp -r "$f" "$TARGET/rules/typescript-$(basename "$f")"; done # 選択された場合
for f in "$ECC_ROOT"/rules/python/*; do [ -e "$f" ] && cp -r "$f" "$TARGET/rules/python-$(basename "$f")"; done # 選択された場合
for f in "$ECC_ROOT"/rules/golang/*; do [ -e "$f" ] && cp -r "$f" "$TARGET/rules/golang-$(basename "$f")"; done # 選択された場合
```

**重要**: ユーザーが言語固有のルールを選択したが、共通ルールを選択しなかった場合、警告します：
Expand Down
9 changes: 5 additions & 4 deletions docs/zh-CN/skills/configure-ecc/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,11 @@ Options:
# Common rules (flat copy into rules/)
cp -r $ECC_ROOT/rules/common/* $TARGET/rules/

# Language-specific rules (flat copy into rules/)
cp -r $ECC_ROOT/rules/typescript/* $TARGET/rules/ # if selected
cp -r $ECC_ROOT/rules/python/* $TARGET/rules/ # if selected
cp -r $ECC_ROOT/rules/golang/* $TARGET/rules/ # if selected
# Language-specific rules (prefixed to avoid overwriting common rules)
# Files like coding-style.md become typescript-coding-style.md, etc.
for f in "$ECC_ROOT"/rules/typescript/*; do [ -e "$f" ] && cp -r "$f" "$TARGET/rules/typescript-$(basename "$f")"; done # if selected
for f in "$ECC_ROOT"/rules/python/*; do [ -e "$f" ] && cp -r "$f" "$TARGET/rules/python-$(basename "$f")"; done # if selected
for f in "$ECC_ROOT"/rules/golang/*; do [ -e "$f" ] && cp -r "$f" "$TARGET/rules/golang-$(basename "$f")"; done # if selected
```

**重要**：如果用户选择了任何特定语言的规则但**没有**选择通用规则，警告他们：
Expand Down
10 changes: 6 additions & 4 deletions skills/configure-ecc/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,11 @@ Execute installation:
# Common rules (flat copy into rules/)
cp -r $ECC_ROOT/rules/common/* $TARGET/rules/

# Language-specific rules (flat copy into rules/)
cp -r $ECC_ROOT/rules/typescript/* $TARGET/rules/ # if selected
cp -r $ECC_ROOT/rules/python/* $TARGET/rules/ # if selected
cp -r $ECC_ROOT/rules/golang/* $TARGET/rules/ # if selected
# Language-specific rules (prefixed to avoid overwriting common rules)
# Files like coding-style.md become typescript-coding-style.md, etc.
for f in "$ECC_ROOT"/rules/typescript/*; do [ -e "$f" ] && cp -r "$f" "$TARGET/rules/typescript-$(basename "$f")"; done # if selected
for f in "$ECC_ROOT"/rules/python/*; do [ -e "$f" ] && cp -r "$f" "$TARGET/rules/python-$(basename "$f")"; done # if selected
for f in "$ECC_ROOT"/rules/golang/*; do [ -e "$f" ] && cp -r "$f" "$TARGET/rules/golang-$(basename "$f")"; done # if selected
Comment on lines +226 to +228
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve nested rule layout for Claude manual installs

When configure-ecc is used to install rules into ~/.claude or .claude, these loops rename rules/<language>/*.md into flat files like typescript-coding-style.md. That no longer matches the supported Claude layout: the production installer keeps rules/common/... and rules/<language>/... directories (scripts/lib/install-executor.js:235-260, verified by tests/scripts/install-apply.test.js:92-95), and rules/README.md:45-49 explicitly warns that flattening breaks the ../common/ references embedded in the language rule files. Users who follow this new guidance will end up with a manual install that diverges from the tested installer behavior and loses those cross-references.

Useful? React with 👍 / 👎.

```

**Important**: If the user selects any language-specific rules but NOT common rules, warn them:
Expand Down Expand Up @@ -360,6 +361,7 @@ Then print a summary report:

### "Rules not working"
- Rules are flat files, not in subdirectories: `$TARGET/rules/coding-style.md` (correct) vs `$TARGET/rules/common/coding-style.md` (incorrect for flat install)
- Language-specific rules are prefixed: `$TARGET/rules/python-coding-style.md` (correct) vs `$TARGET/rules/coding-style.md` (incorrect — overwrites the common rule)
- Restart Claude Code after installing rules

### "Path reference errors after project-level install"
Expand Down
Loading