docs: expand scanner accuracy and false-positive guidance#42
Conversation
|
Caution Review failedThe pull request is closed. Note
|
| Cohort / File(s) | Summary |
|---|---|
README Documentation README.md |
Reworked top-level navigation (removed Distribution, added API Reference and MiniClaw). Added Discovery section (skipped generated/transient dirs). Introduced findings[].runtimeConfidence taxonomy, weighting/capping rules, MCP Confidence Notes, Scanner Accuracy Notes, JSON Report Shape with example, expanded CLI reference (new flags: --injection, --sandbox, --taint, --deep, --log, --log-format, --corpus and exit codes 0/1/2), and new MiniClaw HTTP API docs. |
Sequence Diagram(s)
sequenceDiagram
participant Client as Client (CLI/HTTP)
participant MiniClaw as MiniClaw HTTP Server
participant Scanner as AgentShield Scanner
participant FS as Repository / Filesystem
participant Report as JSON Report Output
Client->>MiniClaw: HTTP request / start scan
MiniClaw->>Scanner: invoke startMiniClaw / scan request
Scanner->>FS: read repo, skip generated dirs (node_modules, build, .dmux, etc.)
Scanner->>Scanner: analyze manifests, .claude/*, hooks, templates
Scanner->>Report: emit findings with runtimeConfidence and scoring metadata
MiniClaw->>Client: return JSON report / status (exit codes reflected)
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~15 minutes
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately summarizes the main change: expanding documentation for scanner accuracy and false-positive guidance, which is the primary focus of the +236 lines of documentation additions. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
feat/reporter-severity-refresh
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 210: Update the README text in the sentence mentioning "fenced code
blocks and markdown tables" to capitalize "Markdown" (change "markdown tables"
to "Markdown tables") so the proper noun is used; locate the sentence that
describes the `agents-oversized-prompt` rule (the line referencing "fenced code
blocks and markdown tables" and the example agents `chief-of-staff.md` and
`planner.md`) and make the capitalization change there.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 76fe7293-ca32-416f-be38-b80c83748e05
📒 Files selected for processing (1)
README.md
be345e3 to
c43657f
Compare
Summary\n- preserve the remaining hidden AgentShield delta as a reviewable PR\n- add scanner accuracy notes, runtime-confidence guidance, and false-positive triage workflow documentation\n\n## Verification\n- diff is documentation only\n
Summary by cubic
Expands the README with scanner accuracy and severity guidance, adds
runtimeConfidencewith updated scoring across all outputs, and documents a practical false‑positive triage workflow. Also adds JSON report schema, refreshed CLI flags/exit codes, and a new MiniClaw security/API overview.runtimeConfidence(template-example/docs-example0.25x with 10‑pt per‑file cap,plugin-manifest0.5x,project-local-optional0.75x; secrets full weight). JSON/markdown/terminal/HTML now exposeruntimeConfidence.node_modules, build output,.dmux) and de‑emphasizes docs‑only examples and template catalogs.hook-codesignals; refined heuristics (pinnedcurl/wget, Node/Python wrappers, read‑only Docker); targeted severity downgrades forsettings.local.json, specialist agents, and repo‑scoped filesystem MCP; role‑aware agent rules and effective prompt‑size measurement; suppresses example passwords in docs‑like paths.jqtriage commands and links tofalse-positive-audit.md(taxonomy, worksheet, release gate).runtimeConfidenceand score breakdown) and clarifies automation surfaces (CLI, JSON,ecc-agentshield/miniclaw), with packaging notes to prefer JSON over importing internals.--injection,--sandbox,--taint,--deep,--log,--log-format,--corpus) and exit codes.Written for commit c43657f. Summary will update on new commits.
Summary by CodeRabbit
Documentation
runtimeConfidencetaxonomy, scoring/weighting/capping semantics, and scanner accuracy notes.New Features