-
Notifications
You must be signed in to change notification settings - Fork 1
feat: [INFRA-240] add NuGet to sign artifacts workflow #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: [INFRA-240] add NuGet to sign artifacts workflow #85
Conversation
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/reusable_sign-artifacts.yaml |
Implements NuGet signing step with SSL.com credentials validation and enables malware blocking |
.github/workflows/test_sign-artifacts-workflow.yaml |
Adds SSL.com secrets and new verify-nuget-signatures job; updates workflow ref to v2.0.2 |
.github/workflows/sign-artifacts/README.md |
Documents NuGet signing support, SSL.com secrets requirements, and artifact layout changes |
.github/workflows/test_execute-build-workflow.yaml |
Updates workflow reference to v2.0.2 |
.github/workflows/test_deploy-artifacts-workflow.yaml |
Updates workflow reference to v2.0.2 |
.github/workflows/test_create-release-bundle-workflow.yaml |
Updates workflow reference to v2.0.2 |
.github/workflows/deploy-artifacts/create-test-fixtures.sh |
Adds NuGet package to test fixtures |
.github/workflows/deploy-artifacts/test-entrypoint.sh |
Updates expected upload command counts to account for added .nupkg file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Verify NuGet Signatures | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| export PATH="$HOME/.dotnet/tools:$PATH" | ||
| shopt -s nullglob globstar | ||
| mapfile -t pkgs < <(printf '%s\n' signed/**/*.nupkg) | ||
| echo "Found ${#pkgs[@]} .nupkg files" | ||
| if [ "${#pkgs[@]}" -lt 1 ]; then | ||
| echo "No .nupkg files found under signed/" >&2 | ||
| exit 1 | ||
| fi | ||
| for p in "${pkgs[@]}"; do | ||
| echo "Verifying $p" | ||
| dotnet nuget verify "$p" --all | ||
| done |
Copilot
AI
Nov 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dotnet command is used to verify NuGet signatures, but the .NET SDK is not installed in this job. Ubuntu 22.04 runners may have the .NET SDK pre-installed, but this is not guaranteed and versions may change. Consider adding an explicit step to install the .NET SDK using actions/setup-dotnet to ensure consistent behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request into this feature branch to apply changes based on this feedback
|
@arrowplum I've opened a new pull request, #86, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * fix: add explicit .NET SDK setup step for NuGet verification Co-authored-by: arrowplum <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: arrowplum <[email protected]>
Brings the core of #29 up into the modern shared workflows.
This PR adds NuGet package signing. The workflow dowloads unsigned artifacts, detects
.nupkgfiles, signs them using SSL.com credentials, and uploads signed artifacts.See
.nupkgfiles