VEC-556 detect memory and set jvm options #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arrowplum
commented
Mar 12, 2025
•
arrowplum
commented
- Detect memory and set java limits in init container
- Attempt at validating config especially allowing missing optional but enforcing required
- Many more tests
…erospike Vector Search init container
- Add JVM options calculation based on container memory limits - Add test coverage for JVM options generation - Update Helm chart to support JVM options configuration - Improve error handling and logging for JVM option generation
arrowplum
commented
Mar 13, 2025
- Added detailed logging for heartbeat configuration checks and seed generation. - Enhanced error handling to skip optional heartbeat setup gracefully. - Updated Helm chart to include a new volume for aerospike-secret and improved init container configuration. - Refactored code to streamline heartbeat seed DNS name generation and configuration.
- Introduced service account token path for Kubernetes integration. - Enhanced test environment setup with mock service account token. - Improved JVM options calculation and testing, ensuring proper handling of environment variables. - Removed unnecessary podinfo volume from Helm chart configuration. - Updated logging for JVM options and configuration file writing.
…or Search - Added mandatory field checks for configuration in writeConfig function. - Improved error handling for missing or invalid configuration fields. - Expanded test cases to cover minimal and maximal configuration scenarios. - Introduced YAML unmarshalling to verify configuration format in tests. - Updated logging and error messages for better clarity during configuration writing.
- Updated JVM options management to write options to a file instead of using environment variables. - Introduced a new function to handle writing JVM options with proper error handling and file permissions. - Enhanced unit tests for JVM options to verify file content and permissions. - Removed the deprecated ConfigMap for JVM options from Helm chart. - Updated statefulset configuration to read JVM options from the new file location.
arrowplum
changed the title
- Fixed the image tag syntax in the init container configuration. - Streamlined the conditional port configuration for service, manage, and interconnect sections in the statefulset template. - Updated the command for the main container to use JAVA_TOOL_OPTIONS instead of JAVA_OPTS for better compatibility.
- Introduced a new workflow to automate testing of the init container. - Configured the workflow to run on pushes and pull requests to the main branch. - Set up Go environment and installed dependencies before executing tests.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…container workflow (unbreaks signing action) - Changed the path for the GPG setup action in the build-chart-jfrog workflow. - Added permissions for reading contents and writing pull requests in the test-init-container workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.