Skip to content

Conversation

@juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Oct 14, 2025

Extra Changes

  • remove_bin(): fix bug where passing an invalid metadata dictionary as an argument does not raise an exception
  • remove_bin(): fix bug when metadata dictionary is not set, set to None, or set to a dictionary without a "ttl" key, the command-level write policy's ttl does not get used, or the client-level write policy's ttl if the command-level policy is not set
  • put(): remove unnecessary as_record_init
  • put(): fix potential memory leaks when an invalid type is passed as a bin name, or when the bin name is longer than the maximum 15 chars limit

https://aerospike-python-client--850.org.readthedocs.build/en/850/aerospike.html#:~:text=validate_keys,-(bool

TODO:

  • docs for metadata dictionary not specific enough
  • test

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 79.24528% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.39%. Comparing base (34c2e3f) to head (ac4ff3d).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/conversions.c 74.41% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #850      +/-   ##
==========================================
+ Coverage   82.35%   82.39%   +0.03%     
==========================================
  Files          99       99              
  Lines       14379    14358      -21     
==========================================
- Hits        11842    11830      -12     
+ Misses       2537     2528       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…red if it is invalid, and the command-level/client config-level write policy's ttl should be applied like the other write commands to be consistent.
…is not called when py_bins_dict is an invalid python type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants