-
Notifications
You must be signed in to change notification settings - Fork 112
[CLIENT-3167] Add option to validate keys for metadata dictionary #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Parent:
FF to Dev
juliannguyen4
wants to merge
29
commits into
dev
Choose a base branch
from
CLIENT-3167-validate-metadata-dictionary
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+209
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #850 +/- ##
==========================================
+ Coverage 82.35% 82.39% +0.03%
==========================================
Files 99 99
Lines 14379 14358 -21
==========================================
- Hits 11842 11830 -12
+ Misses 2537 2528 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…red if it is invalid, and the command-level/client config-level write policy's ttl should be applied like the other write commands to be consistent.
…is not called when py_bins_dict is an invalid python type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra Changes
https://aerospike-python-client--850.org.readthedocs.build/en/850/aerospike.html#:~:text=validate_keys,-(bool
TODO:
docs for metadata dictionary not specific enoughtest