Skip to content

[CLIENT-3106] Clean up dead code #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
+0 −49
Draft

[CLIENT-3106] Clean up dead code #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2b6dba
clean up dead code
juliannguyen4 Aug 18, 2025
1887047
Merge remote-tracking branch 'origin/dev' into CLIENT-3106-clean-up-d…
juliannguyen4 Oct 14, 2025
41803b0
unused declaration
juliannguyen4 Oct 23, 2025
25b150e
Merge remote-tracking branch 'origin/dev' into CLIENT-3106-clean-up-d…
juliannguyen4 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/include/conversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,6 @@ as_status record_to_pyobject(AerospikeClient *self, as_error *err,
const as_record *rec, const as_key *key,
PyObject **obj);

as_status record_to_resultpyobject(AerospikeClient *self, as_error *err,
const as_record *rec, PyObject **obj);

as_status operate_bins_to_pyobject(AerospikeClient *self, as_error *err,
const as_record *rec, PyObject **py_bins);

Expand All @@ -151,11 +148,6 @@ as_status bins_to_pyobject(AerospikeClient *self, as_error *err,

void error_to_pyobject(const as_error *err, PyObject **obj);

as_status pyobject_to_astype_write(AerospikeClient *self, as_error *err,
PyObject *py_value, as_val **val,
as_static_pool *static_pool,
int serializer_type);

as_status as_privilege_to_pyobject(as_error *err, as_privilege privileges[],
PyObject *py_as_privilege,
int privilege_size);
Expand Down
41 changes: 0 additions & 41 deletions src/main/conversions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2001,47 +2001,6 @@ as_status do_record_to_pyobject(AerospikeClient *self, as_error *err,
return err->code;
}

as_status record_to_resultpyobject(AerospikeClient *self, as_error *err,
const as_record *rec, PyObject **obj)
{
as_error_reset(err);
*obj = NULL;

if (!rec) {
return as_error_update(err, AEROSPIKE_ERR_CLIENT, "record is null");
}

PyObject *py_rec = NULL;
PyObject *py_rec_meta = NULL;
PyObject *py_rec_bins = NULL;

if (metadata_to_pyobject(err, rec, &py_rec_meta) != AEROSPIKE_OK) {
return err->code;
}

if (bins_to_pyobject(self, err, rec, &py_rec_bins, false) != AEROSPIKE_OK) {
Py_CLEAR(py_rec_meta);
return err->code;
}

if (!py_rec_meta) {
Py_INCREF(Py_None);
py_rec_meta = Py_None;
}

if (!py_rec_bins) {
Py_INCREF(Py_None);
py_rec_bins = Py_None;
}

py_rec = PyTuple_New(2);
PyTuple_SetItem(py_rec, 0, py_rec_meta);
PyTuple_SetItem(py_rec, 1, py_rec_bins);

*obj = py_rec;
return err->code;
}

as_status record_to_pyobject(AerospikeClient *self, as_error *err,
const as_record *rec, const as_key *key,
PyObject **obj)
Expand Down
Loading