WIP: AEROGEAR-8989 - Showcase app config #674
Conversation
|
@austincunningham - ready for a review 👍 |
|
|
||
| . Open your {mobile-client} in Mobile Developer Console. | ||
| . Copy the `mobile-services.json` configuration to your clipboard. | ||
| . Save the contents of the clipboard to a new file called `mobile-services.json`. |
There was a problem hiding this comment.
This is for the showcase app, which will have a mobile-service.js file already in git https://github.com/aerogear/ionic-showcase/blob/master/src/mobile-services.js , don't think there is any need to create mobile-service.json. Replace the contents of the config object in mobile-services.js with the contents of mobile-service.json. i.e. everything between the {} inclusive . This is really hard to describe.
There was a problem hiding this comment.
I don't follow @austincunningham - would you mind making this technical change and I'll review it from a docs point of view (if there is a need)?
There was a problem hiding this comment.
Actually, I think I know what you are asking. Let me give it a go.
There was a problem hiding this comment.
As the show case is only an ionic app, there is no need for the configs for the other platforms,
There was a problem hiding this comment.
Given that there is no need for the configs for the other platforms, I've removed them. In addition to this, I've added a note to this section to make it clear to the reader that this section is only for the Ionic platform.
That addresses your feedback. Can you review it again please?
|
@austincunningham - ready for review. |
|
@finp - this is ready for a final review |
|
Just a note: I think this work is related to #551 |
|
@austincunningham does this make sense for ionic? or is it just that it doesn't make sense for showcase? |
jstaffor
changed the title
|
After discussing on docs stand-up, this work is now parked. |
|
Update: the documentation issue for ionic will be resolved by aerogear/aerogear-js-sdk#318 |
Motivation
https://issues.jboss.org/browse/AEROGEAR-8989