Generic events by client_id

[dmittriy13]

Motivation

Add label "client_id" to generic event counters.

What

Add label "client_id" to generic event counters.

Why

To separate metrics by client_id.

How

Added label "client_id" to generic event counters.

Verification Steps

1. Build the SPI from this branch and start Keycloak with it.
2. Login with users
3. Open the metrics endpoint in a browser.

Checklist:

• Code has been tested locally by PR requester
• Changes have been successfully verified by another team member

Progress

• Finished task

Additional Notes

[pb82]

@dmittriy13 the change looks fine, the only concern is that this increases the total amount of logs (because now those metrics are multiplied by the number of clients). I think the number of clients is typically rather low, but still something to be aware.

Is there a specific use case for requiring this grouping?

[efbgirotto]

Is there a specific use case for requiring this grouping?

I have a use case where I need to measure not all generic event types but only TOKEN_EXCHANGE and TOKEN_EXCHANGE_ERROR. Maybe this PR could evolve to enable labels on generic fields by configuration.

[alexted]

@dmittriy13 Is this PR still relevant?

[dmittriy13]

@dmittriy13 Is this PR still relevant?

Hi, this is no longer relevant, this is not the intended use of metric tags because tag values should be finite.