Initial public version of the Mongo-Initializr

[JacobusXIII]

Added the Mongo-Initializr scripts and some helper scripts for building the Docker images.

[Gijsvanhorn]

LGTM

[SerhatG]

I tried some stuff.. mostly some formatting/linting or stuff that worked well for me in bash scripting (which makes it also more readable for non-shells scripting people).
Though I didn't do it everywhere, just when I was making a change, I updated the formatting as well.

I didn't check some Docker construct fully yet.

[SerhatG]

This overrides the default mongo entrypoint: https://github.com/docker-library/mongo/blob/e3137ef2ab515a4b7b02487ec72cf3a02d14b667/7.0/docker-entrypoint.sh

Which contains some fixes and workarounds and also does stuff like creating default database and user/passwords based on ENV variables. For the sake of compatibility we would need to call that one somewhere unless it breaks some of the things we do.

Our entrypoint seems to point directly to mongo-initializr.sh. Technically we could remove ours and just use the as a CMD, or use a RUN construct as done in the example.

[JacobusXIII]

I don't like depending on the original entrypoint script. I don't fully understand the script and I'm not sure if it can cause any problems.

We should run our script as ENTRYPOINT.
In the original base image mongod is set as CMD what I would like to keep as is.
And the disadvantage of a RUN is that it cannot be overwritten like the ENTRYPOINT.

[SerhatG]

If this container is build using the example.. How does it start the database?
If I read it correctly.. it will run mongo-initializr.sh which will only start mongo if USERNAME/PASS are set and you want to do a build.

[JacobusXIII]

If this container is build using the example.. How does it start the database? If I read it correctly.. it will run mongo-initializr.sh which will only start mongo if USERNAME/PASS are set and you want to do a build.

The database is started using the CMD instruction in the mongo base image.

[SerhatG]

If this container is build using the example.. How does it start the database? If I read it correctly.. it will run mongo-initializr.sh which will only start mongo if USERNAME/PASS are set and you want to do a build.

The database is started using the CMD instruction in the mongo base image.

If I understand correctly the CMD is passed to the entrypoint as extra arguments, which the entrypoint can choose to execute or wrap around. That's why most entrypoints end with a call like this.

Overview with how ENTRYPOINT and CMD interact:
https://docs.docker.com/reference/dockerfile/#understand-how-cmd-and-entrypoint-interact

Didn't know there was a difference between ENTRYPOINT a b and ENTRYPOINT ["a", "b"]. 😱

Though I also just read a note on that page saying it gets reset in our particular case..

If CMD is defined from the base image, setting ENTRYPOINT will reset CMD to an empty value. In this scenario, CMD must be defined in the current image to have a value.

[JacobusXIII]

@SerhatG It is now possible to initialize the database during the docker build. Can you please review the code again?

[JacobusXIII]

@SerhatG It is now possible to initialize the database during the docker build. Can you please review the code again?

See Dockerfile for initializing the database during the Docker build. in README.md.

obsolete

Much has changed since first review

[wtenbosch]

LGTM
I don't see any apparent issues (but I also don't have a lot of shell scripting experience)