feat: add multiplexing config #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
woluohenga
commented
Feb 23, 2023
woluohenga
commented
- add ProtocolConfig, put codec in it
- add open_multiplexing config
Signed-off-by: woluohenga <[email protected]>
woluohenga
force-pushed
the
feature/modify_api_protocol_config
branch
from
2ed4aea
to
2ecb7b9
Compare
|
This PR is the API for #93 |
zhaohuabing
reviewed
Feb 23, 2023
| // The codec which encodes and decodes the application protocol. | ||
| Codec codec = 1; | ||
| // is open multiplexing | ||
| bool open_multiplexing = 2; |
There was a problem hiding this comment.
I think just multiplexing is clear enough.
zhaohuabing
reviewed
Feb 23, 2023
| @@ -151,3 +154,10 @@ message Tracing { | |||
| envoy.config.trace.v3.Tracing.Http provider = 9; | |||
| } | |||
|
|
|||
| message ProtocolConfig { | |||
There was a problem hiding this comment.
I'm thinking that we name it ApplicationProtocol and put all configuration about the application protocol in it.
zhaohuabing
reviewed
Feb 23, 2023
|
Please also add comment to application_protocol and codec to decalare these two fields have been deprecated. |
Signed-off-by: woluohenga <[email protected]>
zhaohuabing
reviewed
Feb 23, 2023
zhaohuabing
reviewed
Feb 23, 2023
| @@ -33,6 +33,7 @@ message MetaProtocolProxy { | |||
| string stat_prefix = 1 [(validate.rules).string = {min_len: 1}]; | |||
|
|
|||
| // The name of the application protocol built on top of meta protocol. | |||
| // this field has been deprecated, now use protocol | |||
There was a problem hiding this comment.
This has been deprecated in favor of name in application_protocol.
zhaohuabing
reviewed
Feb 23, 2023
| @@ -46,6 +47,7 @@ message MetaProtocolProxy { | |||
| } | |||
|
|
|||
| // The codec which encodes and decodes the application protocol. | |||
| // this field has been deprecated, now use protocol | |||
There was a problem hiding this comment.
This has been deprecated in favor of codec in application_protocol.
Signed-off-by: woluohenga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.