Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add meta transmit for brpc mesh #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paisna
Copy link

@paisna paisna commented Jul 3, 2023

add meta transmit for brpc mesh

Signed-off-by: zhangyunping <[email protected]>
@zhaohuabing
Copy link
Member

@tanjunchen @smwyzi Since it's related to brpc, can you please review this PR?

@smwyzi
Copy link
Contributor

smwyzi commented Jul 10, 2023

@tanjunchen @smwyzi Since it's related to brpc, can you please review this PR?

sure,i'd like to review this later

header_magic = buffer.peekBEInt<uint32_t>(pos);
if (header_magic != MAGIC)
{
ENVOY_LOG(warn, "Brpc Header magic_error need={} real={}.", MAGIC, header_magic);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方 header MAGIC 不对,是不是应该报错并返回错误

Copy link

@milad237 milad237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants