Opt #8
Closed
Opt #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
reviewed
May 7, 2022
| @@ -72,6 +75,7 @@ func (m *consulMonitor) watchConsul(stop <-chan struct{}) { | |||
| } else if consulWaitIndex != queryMeta.LastIndex { | |||
| consulWaitIndex = queryMeta.LastIndex | |||
| m.updateServiceRecord() | |||
| time.Sleep(updateServiceRecordWaitTime) | |||
There was a problem hiding this comment.
这个应该是在 consul 端修复吧？ 对于正常的服务变化来说，每次变化后等待 10 分钟再同步会不会延迟太大了？
我建议缺省值设置小一点，例如 1 分钟。但可以提供一个环境变量参数，在 Consul 的故障没有修复之前，你们可以把这个环境变量参数设置大一些，例如 10 分钟。
zhaohuabing
reviewed
May 7, 2022
| return defaultProto | ||
| } | ||
| for _, v := range serviceTags { | ||
| isExist := strings.Contains(v, "proto") |
There was a problem hiding this comment.
建议使用 protocol， proto 是 “原型” 的意思
zhaohuabing
reviewed
May 7, 2022
| @@ -129,7 +129,7 @@ func (s *Controller) mainLoop(stop <-chan struct{}) { | |||
| if err != nil { | |||
| log.Errorf("Failed to synchronize consul services to Istio: %v", err) | |||
| // Retry if failed | |||
| s.pushChannel <- &ChangeEvent{} | |||
| // s.pushChannel <- &ChangeEvent{} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复&优化在使用中发现的一些问题
#5
#6
#7
1、阻塞方式改为非阻塞方式
2、有创建某个se有问题时，会导致其他的创建不成功
3、consul 有变化时，本地由于serviceList中仍然是旧值，导致没有更新本地
4、同步时，由于consul meta或tag中没有指明协议时会走默认的tcp协议，导致不能创建基于http协议的se
5、同步时，在maxIndex不断变化的情况下，不停的从consul sever拉取数据，占用不必要的带宽