-
Notifications
You must be signed in to change notification settings - Fork 222
[ENH] Make transformers inherit TransformerMixin and add CollectionToSeriesWrapper
#2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
# Conflicts: # aeon/testing/estimator_checking/_yield_anomaly_detection_checks.py
# Conflicts: # aeon/anomaly_detection/base.py # aeon/testing/estimator_checking/_yield_anomaly_detection_checks.py # aeon/testing/testing_config.py
# Conflicts: # aeon/testing/testing_config.py # aeon/transformations/collection/compose/tests/test_pipeline.py # aeon/transformations/series/compose/tests/test_pipeline.py
TransformerMixin and add CollectionToSeriesWrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question on the existing fit_transform in BaseTransformer but otherwise LGTM
# Conflicts: # aeon/transformations/collection/__init__.py # aeon/transformations/series/__init__.py
# Conflicts: # aeon/testing/testing_config.py
|
Should be ready @TonyBagnall @baraline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this will solve the issue. Lgtm.
TransformerMixin, which removes the last of the now deprecatedself._estimator_typeattributesSeriesToCollectionBroadcasteras it has the function implemented, other small changesCollectionToSeriesWrapperas a counterpart to the broadcaster