Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log4net dependency #1

Open
wants to merge 73 commits into
base: trunk
Choose a base branch
from
Open

log4net dependency #1

wants to merge 73 commits into from

Conversation

lelmarir
Copy link

Hi,

i'm a novice with C# but it seem that this project miss the log4net dependency, correct me if i'm wrong

soneyworld and others added 30 commits August 19, 2014 12:14
If any Syste.Net.WebException occurs on parsing a JSON response
a CmisConnectionException is thrown with the web exception embedded.
If a new object Id is returned, the refresh operation could throw an object
not found exception. This is fixed by calling the refresh on the newly created
and returned document instead of the old document
(cherry picked from commit ee7e593)
soneyworld and others added 19 commits July 6, 2015 15:18
The Stacktrace now includes the sent server response if available
This could be very helpful if the server stack trace has also been
attached to the HTTP Response
This reverts commit bb79e24.
Used a newer API than it is available in configured .Net
The error content wasn't passed to the base exception
in all conditions. This is fixed now.
Now CmisConnectionException are thrown if the connection on GET requests
is gone. It was a CmisRuntimeException in the past, but is a simple Connection
problem which was wrong detected.
Conflicts:
	DotCMIS/client/client-objectfactory.cs
	DotCMIS/client/client-objects.cs
@@ -40,6 +40,10 @@
<AssemblyOriginatorKeyFile>dotcmis.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<ItemGroup>
<Reference Include="log4net, Version=1.2.13.0, Culture=neutral, PublicKeyToken=669e0ddf0bb1aa2a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\log4net.2.0.3\lib\net40-full\log4net.dll</HintPath>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path does not exist on computers other than yours. Embedding the log4net DLL (for instance at the root of the project) could be a solution.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said, i'm a c# newbie; but the packages folder should be the NuGet managed folder for dependency, so it should put there the dll as instructed by the <package id="log4net" ...> entry in packages.config file.
Isn't it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now i can see: the problem is that i'm using this project as a submodule of CmisSync, so the resulting path is related to the root project that indeed has the packages folder.
I don't want to add a dll to the project; it need to be managed by NuGet, but i don't know how to solve this

lelmarir and others added 4 commits February 10, 2016 09:30
# Conflicts:
#	DotCMIS/DotCMIS.csproj
#	DotCMIS/binding/atompub/atompub-parser.cs
#	DotCMIS/binding/http.cs
#	DotCMIS/packages.config
# Conflicts:
#	DotCMIS/binding/http.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants