Fix Code Scanning Bugs #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
theztefan
reviewed
Dec 4, 2024
theztefan
reviewed
Dec 4, 2024
theztefan
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
@GeekMasher looks good!
I can see the feature of making a dismissal comment mandatory be used by few organizations.
We should probably expand and add it to Secret Scanning and Dependabot alerts resolution as well next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates and improvements to the
ghas-reviewer-appproject. The most important changes involve version updates, configuration adjustments, and enhancements to the logging and error handling mechanisms.Version and Configuration Updates:
.release.yml: Updated the repository reference and incremented the version to0.6.0.README.md: Updated Docker commands to use the new versionv0.6.0instead ofmain. [1] [2]ghasreview/__init__.py: Updated the application version to0.6.0.Code Enhancements:
ghasreview/__main__.py: Modified the app's run command to use a configurable debug setting from the environment.ghasreview/app.py: Improved logging messages, added a severity check comment, and enhanced error handling for team creation and alert reopening processes. [1] [2]Logging and Error Handling Improvements:
ghasreview/client.py: Changed logging levels from debug to error for better visibility when a team does not exist and ensured correct URL usage increateTeammethod. [1] [2]ghasreview/setup.py: Added a debug configuration setting to the setup process.