-
Couldn't load subscription status.
- Fork 2
feat: Add getPacks method to retrieve installed CodeQL packs #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -413,6 +413,69 @@ export class CodeQLService { | |||||||||
| return [...new Set(results)]; // Remove any duplicates just in case | ||||||||||
| } | ||||||||||
|
|
||||||||||
| public async getPacks(): Promise<string[]> { | ||||||||||
| this.logger.logServiceCall("CodeQLService", "getPacks", "started"); | ||||||||||
| var packs: string[] = []; | ||||||||||
|
|
||||||||||
| try { | ||||||||||
| const config = vscode.workspace.getConfiguration("codeql-scanner"); | ||||||||||
| const codeqlPath = config.get<string>("codeqlPath", "codeql"); | ||||||||||
|
|
||||||||||
| this.logger.info( | ||||||||||
| "CodeQLService", | ||||||||||
| `Getting installed CodeQL packs using CLI at ${codeqlPath}` | ||||||||||
| ); | ||||||||||
|
|
||||||||||
| const cmd = `${codeqlPath} resolve packs --format=json`; | ||||||||||
| this.logger.info( | ||||||||||
| "CodeQLService", | ||||||||||
| `Running command to get installed CodeQL packs: ${cmd}` | ||||||||||
| ); | ||||||||||
| const { stdout } = await execAsync(cmd); | ||||||||||
|
|
||||||||||
| this.logger.info( | ||||||||||
| "CodeQLService", | ||||||||||
| "Successfully retrieved installed CodeQL packs" | ||||||||||
| ); | ||||||||||
|
|
||||||||||
| const packsInfo = JSON.parse(stdout); | ||||||||||
|
|
||||||||||
| // Reverse steps | ||||||||||
GeekMasher marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
| const steps = packsInfo.steps || []; | ||||||||||
| for (const step of steps.reverse()) { | ||||||||||
| for (const scans of step.scans || []) { | ||||||||||
| const found = scans.found || {}; | ||||||||||
| // For each key, add the pack name to the list | ||||||||||
| for (const packName of Object.keys(found)) { | ||||||||||
| if (!packs.includes(packName)) { | ||||||||||
| packs.push(packName); | ||||||||||
|
Comment on lines
+450
to
+451
|
||||||||||
| if (!packs.includes(packName)) { | |
| packs.push(packName); | |
| if (!packs.has(packName)) { | |
| packs.add(packName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'const' instead of 'var' for block-scoped variable declaration. Since 'packs' is reassigned through array methods rather than variable reassignment, it can be declared as const.