test(desktop-e2e): accept "just now" on channel link tooltips - #51
Merged
Conversation
The channel-tooltip assertion required `Active \d+[mhdw] ago`, so both themes failed when activity was recent enough to render `Active just now`. Mirror the message-chip regex already in the same spec. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Adrien Lacombe <adrienlacombe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop Smoke E2E (4) went red on
mainafter #50 because the channel-link tooltip footer can renderActive just nowwhen activity is recent. The assertion only allowedActive \d+[mhdw] ago.This mirrors the message-chip regex already in the same spec:
/#general · .+ · (just now|\d+[mhdw] ago)/so the channel tooltip now accepts:
/Public channel · Active (just now|\d+[mhdw] ago)/Both themes (
buzzandcatppuccin-mocha) share that assertion. No product behavior change.Related issue
N/A. None found. Fixes the Desktop Smoke E2E (4) failure on CI run 32482527983 after #50.
Testing
desktop/tests/e2e/tooltip-semantics.spec.ts.bitcoinmarkets:///MESSAGE_LINK_SCHEMEedits.Walkthrough
The failing expect was the first
expectMutedSupportingTextinlink tooltip supporting text uses the muted secondary foreground. The UI renderedPublic channel · Active just now; the regex now allows that form the same way the following message-chip assertion already does.