Allow the adversarial_filter benchmark for the DataFusion repos#9
Open
adriangb wants to merge 1 commit into
Open
Allow the adversarial_filter benchmark for the DataFusion repos#9adriangb wants to merge 1 commit into
adriangb wants to merge 1 commit into
Conversation
Add `adversarial_filter` to the `standard` allowlist for both `apache/datafusion` and `adriangb/datafusion`. It is a `sql_benchmarks` suite (run via `bench.sh run adversarial_filter`) that stress-tests adaptive filter conjunct reordering; toggle the optimization per side with `DATAFUSION_EXECUTION_ADAPTIVE_FILTER_REORDERING`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
adversarial_filterto thestandardbenchmark allowlist for bothapache/datafusionandadriangb/datafusion.It's a
sql_benchmarkssuite (added in apache/datafusion#22698) that stress-tests adaptive filter conjunct reordering: five equally-expensive regexp predicates with the selective one written last — a case the static cost heuristic and BinaryExpr pre-selection both leave mis-ordered.bench.sh run adversarial_filter→BENCH_NAME=adversarial_filter cargo bench --bench sql.DATAFUSION_EXECUTION_ADAPTIVE_FILTER_REORDERING(the same config env var the dfbench suites read viaSessionConfig::from_env).Because the suite + flag only exist on the feature branch, compare it by pointing both
baselineandchangedat that branch with the flag differing per side.Requires a controller redeploy to take effect (allowlist is baked into
BENCHMARK_CONFIG).🤖 Generated with Claude Code