fix(dsh): isolate recalled memory from prompt templates - #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
DSH treats every dynamic context as prompt-template source. Graph Memory previously inserted recalled nodes and episodic messages directly into that source, so ordinary Vue, Handlebars, Liquid, Angular, or CI expressions could be parsed as DSH variables and abort the entire turn. Storage was not the problem; the missing data/template trust boundary was.
Architectural fix
assembleContexthost-neutral and centralize this contract in one reusable helper.Verification
@deepseek-ai/dsh-system-prompt@0.0.1-rc.1: failure reproduced before the fix.npm run buildandnpm run build:dshpass.Thank you @meyaomiao for the detailed root-cause trace and local validation in #79, and @vongostev for independently reporting the same failure mode and emphasizing that even valid-looking variable names are unsafe in #80.
Closes #79
Closes #80