Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up existing CppUnit #38

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Hook up existing CppUnit #38

merged 2 commits into from
Jan 24, 2024

Conversation

lanodan
Copy link
Contributor

@lanodan lanodan commented Mar 5, 2023

  • Use pkg-config for cppunit
  • test/Makefile.am: Add unittest into TESTS

@rzr
Copy link
Collaborator

rzr commented Mar 5, 2023

LGTM good catch , maybe we need to pkgconfig pinball-config too

@lanodan
Copy link
Contributor Author

lanodan commented Mar 5, 2023 via email

@rzr
Copy link
Collaborator

rzr commented Mar 5, 2023

yea there is no rush

for next release in 2042 ;)

@lanodan @rzr
Use pkg-config for cppunit
8e27cd7 
cppunit-config doesn't seems to exist anymore.
According to cppunit NEWS file, pkgconfig support was added in 1.11.4, which
is a safe bet as all distros known by repology.org are using at least 1.12.1
@lanodan @rzr
test/Makefile.am: Add unittest into TESTS
9c2dba0
@rzr rzr force-pushed the cppunit-pkgconfig branch from 80230ab to 9c2dba0 Compare January 24, 2024 20:21
@rzr rzr merged commit de5c560 into adoptware:master Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzr rzr rzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanodan @rzr