feat: add support for installing specific versions of packages #4878
Conversation
| const packageToInstall = npmPackageVersion | ||
| ? `${npmPackageName}@${npmPackageVersion}` | ||
| : npmPackageName | ||
|
|
||
| try { | ||
| await installPackage(npmPackageName, { | ||
| await installPackage(packageToInstall, { |
There was a problem hiding this comment.
This doesn't work for the packages that are filesystem based installs, like those used in the tests. Really the actual installation should probably be mocked out in most of the tests, since we can probably assume that installPackage does its thing.
There was a problem hiding this comment.
The reason we don't mock is, because we have been bitten in the past with the install-pkg package. They swapped the underlying fetch library that had different timeout settings and suddenly all installations taking longer than x timeout started failing.
| const packageVersion = await fs.contentsJson('package.json') | ||
| console.log({ packageVersion }) |
There was a problem hiding this comment.
This was me trying to grab the root package.json so I could just use an already installed package at it's installed version, but uh, that doesn't work due to scoping of the filesystem — I'd probably have to do something different.
Idea was to use like the edge.js package from the root package.json as a node ace add edge.js <version from package.json> type thing, such that we're not hitting the network to install a specific version, whilst avoiding the filesystem path based installs which don't support versions.
There was a problem hiding this comment.
Maybe we can read it manually using the fs package of Node.js vs the test helper?
|
This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request |
|
Haven't had time to progress on this, but I still think it's a good feature if we can figure out how to reasonably test it. |
|
Yup, no worries, we can keep it open. |
🔗 Linked issue
This enables what's described in adonisjs/ace#163
However, I cannot think of a way to actually test this, since
@antfu/install-pkgdoesn't provide a way to not actually do anything (i.e., run under test)❓ Type of change
📚 Description
Currently when using
node ace add <package>it's not possible to install a prerelease or specific released version of a package, so if we have@adonisjs/transmitreleasing a prerelease ofv5.0.0-next.0which isn't thelatesttag, but thenexttag, we can't install that throughnode ace add, instead we'd have to install manually viapackage.jsonthe specific version, and then callnode ace configure <package>separately.The way the tests are written, I cannot see a way to actually add test coverage for this.
📝 Checklist