fix(commands): use Array#some instead of Array#includes for type-safety

adonisjs · Nov 25, 2024 · c598b55 · c598b55
1 parent 8696178
commit c598b55
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/commands/add.ts b/commands/add.ts
@@ -44,11 +44,13 @@ export default class Add extends BaseCommand {
    * Detect the package manager to use
    */
   async #getPackageManager() {
-    const pkgManager =
+    const packageManager =
       this.packageManager || (await detectPackageManager(this.app.makePath())) || 'npm'
 
-    if (KNOWN_PACKAGE_MANAGERS.includes(pkgManager)) {
-      return pkgManager
+    if (
+      KNOWN_PACKAGE_MANAGERS.some((knownPackageManager) => knownPackageManager === packageManager)
+    ) {
+      return packageManager as (typeof KNOWN_PACKAGE_MANAGERS)[number] | undefined
     }
 
     throw new Error('Invalid package manager. Must be one of npm, pnpm, bun or yarn')