Skip to content

⚡ Bolt: Optimize validate_shell_safe_string performance #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adolago wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Optimize validate_shell_safe_string performance #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added bench_security
View file
Open in desktop
Binary file not shown.
13 changes: 8 additions & 5 deletions src/modules/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,14 @@ pub fn validate_shell_safe_string(value: &str, param_name: &str) -> ModuleResult
}

// Reject shell metacharacters that enable command injection
const SHELL_METACHARACTERS: &[char] = &[
'$', '`', '|', '&', ';', '<', '>', '(', ')', '\n', '\r', '\t', '\\', '!',
];

if value.chars().any(|c| SHELL_METACHARACTERS.contains(&c)) {
// Optimization: Check bytes directly to avoid UTF-8 decoding and linear slice scan.
// All these metacharacters are ASCII (single byte), so this is safe and correct even for UTF-8 strings.
if value.bytes().any(|b| matches!(b,
b'$' | b'`' | b'|' | b'&' | b';' | b'<' | b'>' | b'(' | b')' | b'\n' | b'\r' | b'\t' | b'\\' | b'!'
)) {
const SHELL_METACHARACTERS: &[char] = &[
'$', '`', '|', '&', ';', '<', '>', '(', ')', '\n', '\r', '\t', '\\', '!',
];
let found_chars: Vec<String> = value
.chars()
.filter(|c| SHELL_METACHARACTERS.contains(c))
Expand Down
Loading