Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-122611 - [GH Action] Old browser function detection #423

Merged
merged 10 commits into from
Feb 1, 2023
Merged

MWPW-122611 - [GH Action] Old browser function detection #423

merged 10 commits into from
Feb 1, 2023

Conversation

jckautzmann
Copy link
Contributor

  • adds a Github action to check if the code is compatible with the Milo supported browsers

Resolves: MWPW-122611

A few notes:

  1. The current code base is compatible: this action doesn’t output any errors when it is run on main.
  2. As eslint - without the changes from this PR - throws 432 errors when it is run on the main branch, the GH action is only running eslint with specific plugins (defined in .eslintrc-supported-browsers.js) and ignores the plugins defined in .eslintrc.js.
  3. Supported browsers for Milo projects (according to [0]):
last 1 chrome version
last 1 firefox version
last 1 edge version
safari >= 14
ios_saf >= 14
  1. Sample errors: the action would throw such similar errors for Safari version >= 13:
/home/runner/work/milo/milo/libs/blocks/caas-config/caas-config.js
59 592:19 error For safari 13.0.0: ES2020 optional chaining is forbidden ecmalist/no-optional-chaining
60 612:19 error ClipboardItem is not supported in Safari 13 compat/compat
61 613:5 error navigator.clipboard() is not supported in Safari 13 compat/compat
62 637:49 error navigator.clipboard() is not supported in Safari 13 compat/compat
63 637:58 error For safari 13.0.0: ES2020 optional chaining is forbidden ecmalist/no-optional-chaining
64
  1. The action is based on following eslint plugins:
eslint-plugin-compat
eslint-plugin-ecmalist
  1. I verified that the action detects following features:
String.replaceAll
static import
dynamic import
String.prototype.replaceAll()
Optional chaining (?.)
fetch
Array.prototype.includes
  1. It does not detect:
Element.replaceChildren()

I created an issue at [1].

[0] https://milo.adobe.com/wiki/test-automation/test-automation-framework#browser--platform-support-matrix
[1] amilajack/eslint-plugin-compat#526

@jckautzmann
MWPW-122611 - [GH Action] Old browser function detection
ce34cbd 
- add a Github action to check for unsupported functions
@jckautzmann
MWPW-122611 - [GH Action] Old browser function detection
2eb8769 
- add a Github action to check for unsupported functions
@jckautzmann
MWPW-122611 - [GH Action] Old browser function detection
f1fe1c8 
- add a Github action to check for unsupported functions
@jckautzmann
MWPW-122611 - [GH Action] Old browser function detection
73982bf 
- add a Github action to check for unsupported functions
@jckautzmann
MWPW-122611 - [GH Action] Old browser function detection
530e41b 
- add a Github action to check for unsupported functions
@jckautzmann
MWPW-122611 - [GH Action] Old browser function detection
65d6410 
- add a Github action to check for unsupported functions
@jckautzmann
MWPW-122611 - [GH Action] Old browser function detection
7f970ac 
- add a Github action to check for unsupported functions
@jckautzmann
Merge branch 'adobecom:main' into main
b4d07dc
@jckautzmann
MWPW-122611 - [GH Action] Old browser function detection
0f8a15e 
- add a Github action to check for unsupported functions
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Jan 26, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

chrischrischris
chrischrischris approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@chrischrischris chrischrischris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful

amauch-adobe
amauch-adobe approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have no concerns based on the implementation of the browser supported by the matrix chart. Approved.

@amauch-adobe amauch-adobe added the verified PR has been E2E tested by a reviewer label Feb 1, 2023
@amauch-adobe amauch-adobe merged commit d89a15a into adobecom:main Feb 1, 2023
mokimo added a commit that referenced this pull request Feb 2, 2023
@mokimo @saugatmalla
@auniverseaway @rgclayton @meganthecoder @chrischrischris @msagolj @Blainegunn @janaki-r-bhagwath @So1ene @seanchoi-dev @jckautzmann @amauch-adobe @fullcolorcoder
Merge main into feds gnav (#436)
91146cf 
* MWPW-122131 - Embed Blocks (#348)

* add twitter auto_block

* add tiktok

* add tiktok test

* add vimeo

* add instagram

* add slideshare

* minor fix

* fix vimeo player link

* fix vimeo url check

* PR feedback

Co-authored-by: Chris Millar <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>

* MWPW-120782 - Fix Chart Color Order (#393)

* MWPW-109331 - Carousel (#375)

* Carousel v1

* PR feedback, clean up

* PR feedback. Clean up.

Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Chris Peyer <[email protected]>

* MWPW-124631 check if adobe logo block exists in document (#406)

check if adobe logo block exists in doc

* Migrate Walls.io (#378)

* add walls.io block

* add test

* fix css

* fix url vulnerability

* pr feedback

* fix vulnerability

* pr feedback

* MWPW-124632 [Milo] No character count in the review component text box (#407)

* MWPW-124584 (#411)

Co-authored-by: Blaine Gunn <[email protected]>

* MWPW-124845 - Start Project button missing for only some projects (#409)

MWPW-124845 - Start Project button missing for only English Copy Projects

- update start button show condition to handle the case where there are no translation projects

Resolves: MWPW-124845

* MWPW-124277 - Link Localization not working for some links in Gnav and Footer (#396)

- call decorateLinks for gnav in gnav init instead of individual blocks
- removed decorateSVG and localizeLink instances as it is called in decorateLinks
- added tests to verify link localization in gnav menu, breadcrumb, cta, brand link
- call decorateLinks for footer links in init method
- added try catch in utils for empty href or malformed href
- fix https://business.adobe.com/au getting converted to https://business.adobe.com/au/au
- add test for this fix
- Support www.adobe.com link localization and add test for the same

Resolves: MWPW-124277

* MWPW-124277 - Regression Fix Link Localization (#416)

MWPW-124277 - Regression Fix Link Localization for

- Retaining the per menu localize link to avoid regression issue noticed with few links not being localized.

Resolves: MWPW-124277

* MWPW-123893 - Review Schema (#415)

* Add product schema to review block

* MWPW-123745 SVG alt text (#401)

* MWPW-123745 SVG alt text

Added feature to svg images to allow for authors to add alt text.

* PR feedback

Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Chris Millar <[email protected]>

* MWPW-120020 - Event-driven Modals (#403)

* Ability to open a modal with a custom event
* Ability to customize the look and behavior of a modal
* Turned GeoRouting on for Milo

* MWPW-1224169 Updated How-to block (#404)

* MWPW-1224169 Updated How-to block

* Fix tests; Update ld json

* Update inline image size

* Die gracefully with old format

* full backwards compatibility

Co-authored-by: ChrisChrisChris <[email protected]>

* small windows fix (#418)

* MWPW-123760 (#383)

Co-authored-by: Chris Millar <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Chris Peyer <[email protected]>

* MWPW-124906 - Embed links inside text block (#420)

Co-authored-by: Chris Millar <[email protected]>

* MWPW-124846 - Loc Support fragments at any level in hierarchy (#419)

Co-authored-by: bhagwath <[email protected]>

* MWPW-125032 Brand Block: using an SVG link for logo breaks gnav rendering (#422)

* MWPW-120802 - Diagonal Labels for Chart (#412)

* MWPW-120802 - Diagonal Labels for Chart

* pr

* Add asset support to library

* Add Franklin customer library support

* Remove 3rd party libraries if not used

* Add utils test coverage (#427)

Co-authored-by: Ryan Clayton <[email protected]>

* A simple `reading-time` block to estimate the reading time of the article (#356)

* A simple  block to estimate the reading time of the article

* reading-time: typo in the css

* reading-time: small change to the css

* reading-time PR review changes

* added placeholders for localization of the '5 min read' text

* [reading-time]: add a placeholder key for singular reading time value

* [reading-time]: less strict scoping for css

* [reading-time]: less strict scoping for css

* [reading-time]: text-align center only if it's in a center section

* reading-time tests added

* reading-time tests added

* Fixing bug for faas import from link clicked. (#424)

* Fixing bug for faas import from link clicked.

* adding ||= sytex.

* same as before.

* MWPW-122611 - [GH Action] Old browser function detection (#423)

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

---------

Co-authored-by: Aaron Mauchley <[email protected]>

* removing display none from accordion (#433)

---------

Co-authored-by: Saugat Malla <[email protected]>
Co-authored-by: Chris Millar <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Megan Thomas <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>
Co-authored-by: Chris Peyer <[email protected]>
Co-authored-by: Mirko Sagolj <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Janaki R Bhagwath <[email protected]>
Co-authored-by: bhagwath <[email protected]>
Co-authored-by: Solène <[email protected]>
Co-authored-by: Sean Choi <[email protected]>
Co-authored-by: jckautzmann <[email protected]>
Co-authored-by: Aaron Mauchley <[email protected]>
Co-authored-by: Brad Johnson <[email protected]>
sukamat pushed a commit to sukamat/milo that referenced this pull request Feb 8, 2023
@jckautzmann @amauch-adobe @sunilkamat
MWPW-122611 - [GH Action] Old browser function detection (adobecom#423)
5af93a6 
* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

---------

Co-authored-by: Aaron Mauchley <[email protected]>
sukamat pushed a commit to sukamat/milo that referenced this pull request Feb 8, 2023
@sunilkamat
Floodgate option added to Sidekick
2c8828e 
base project page

placeholder fg css

connect to SP and init floodgate project

Reads the floodgate project and injects SP data

Add asset support to library

Add Franklin customer library support

Remove 3rd party libraries if not used

Add utils test coverage (adobecom#427)

Co-authored-by: Ryan Clayton <[email protected]>

A simple `reading-time` block to estimate the reading time of the article (adobecom#356)

* A simple  block to estimate the reading time of the article

* reading-time: typo in the css

* reading-time: small change to the css

* reading-time PR review changes

* added placeholders for localization of the '5 min read' text

* [reading-time]: add a placeholder key for singular reading time value

* [reading-time]: less strict scoping for css

* [reading-time]: less strict scoping for css

* [reading-time]: text-align center only if it's in a center section

* reading-time tests added

* reading-time tests added

Fixing bug for faas import from link clicked. (adobecom#424)

* Fixing bug for faas import from link clicked.

* adding ||= sytex.

* same as before.

MWPW-122611 - [GH Action] Old browser function detection (adobecom#423)

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

---------

Co-authored-by: Aaron Mauchley <[email protected]>

removing display none from accordion (adobecom#433)

Media & Z-Pattern updates - content margins and 2-5up grid support (adobecom#429)

* updates to media to support section meta two-five ups

* updated default margins

* Added detail styles to text-transform:uppercase
Removed redundant asside styles.

* test coverate on image w/ out alt text

---------

Co-authored-by: thi64146 <[email protected]>
Co-authored-by: Ryan Clayton <[email protected]>

Update node to v18 (adobecom#440)

MWPW-125458 - Adding chat icon (adobecom#439)

Adding chat icon for bacom use

Co-authored-by: Chris Peyer <[email protected]>

MWPW-124813 Prevent long breadcrumbs overlapping search (adobecom#434)

MWPW-124277: Localize Gnav Sign In Link (adobecom#432)

- Call decorateLinks for gnav sign in

Resolves: MWPW-124277

add ignores similar to loc

project details table markup updated

removed console logs

updated admin page to keep just the copy action

removed copy files placeholder code

clean up and loc config import fix

cleanup

rename app.js to ui.js

floodgate content display updated

cleanup

removed window.projectDetail

refactor
chrischrischris pushed a commit to adobecom/milo-target that referenced this pull request May 22, 2023
@jckautzmann @amauch-adobe
MWPW-122611 - [GH Action] Old browser function detection (adobecom#423)
6d0bcd1 
* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

* MWPW-122611 - [GH Action] Old browser function detection

- add a Github action to check for unsupported functions

---------

Co-authored-by: Aaron Mauchley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amauch-adobe amauch-adobe amauch-adobe approved these changes

@chrischrischris chrischrischris chrischrischris approved these changes

@auniverseaway auniverseaway Awaiting requested review from auniverseaway

Assignees
No one assigned
Labels
verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jckautzmann @chrischrischris @amauch-adobe