-
Notifications
You must be signed in to change notification settings - Fork 235
chore: updated JIRA ticket rules to include 3-part RFC tickets #5908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
| **Note:** For RFC tickets, generate three related tickets that must be completed sequentially: | ||
| 1. RFC authoring and initial review | ||
| 2. Internal discussion shepherding | ||
| 3. External community discussion shepherding | ||
|
|
||
| #### First ticket: RFC authoring | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expands JIRA RFCs from a single ticket into three related tickets.
| Additional acceptance criteria for RFC tickets: | ||
| - RFC has been added to the [Decisions and RFCs wiki|https://wiki.corp.adobe.com/display/AdobeDesign/Decisions+and+RFCs] | ||
| - RFC link has been added to this ticket | ||
| - Announcement posted in {{spectrum-web-reviews}} Slack channel with internal comment deadline (minimum 1 week) | ||
| - Announcement posted in {{spectrum-web-engineering}} Slack channel with internal comment deadline (minimum 1 week) | ||
| - Internal discussion scheduled for SWC team sync after comment period | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This work should happen in the first RFC to tee up the work for the second sprint/ticket.
| (Add any other context, drafts, etc. if you have them) | ||
| ``` | ||
|
|
||
| #### Second ticket: Internal discussion shepherding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of the process is the same regardless of RFC topic so we can get away with using a more explicit template that addresses what needs to happen to the RFC rather than what is in the RFC. I left placeholders for updating the name of the RFC that is shepherded as well as the link to the first ticket.
Description
Adds new rules for RFC JIRA tickets
Motivation and context
The RFC process takes at least three sprints to write, discuss with SWC Team in a sync, and discuss with our community in office hours. It makes sense to create a ticket for each sprint.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
I have reviewed at the Accessibility Practices for this feature, see: [Aria Practices]N/A(https://www.w3.org/TR/wai-aria-practices/) N/AI have added automated tests to cover my changes.N/AI have included a well-written changeset if my change needs to be published.N/AI have included updated documentation if my change required it.N/AReviewer's checklist
Includes thoughtfully written changeset if changes suggested includeN/Apatch,minor, ormajorfeaturesAutomated tests cover all use cases and follow best practices for writingN/AValidated on all supported browsersN/AAll VRTs are approved before the author can update Golden HashN/AManual review test cases
Generate JIRA RFC tickets
git checkout nikkmk/rfc-rulesDevice review
Did it pass in Desktop?N/ADid it pass in (emulated) Mobile?N/ADid it pass in (emulated) iPad?N/A