Skip to content

Conversation

@nikkimk
Copy link
Contributor

@nikkimk nikkimk commented Nov 25, 2025

Description

Adds new rules for RFC JIRA tickets

Motivation and context

The RFC process takes at least three sprints to write, discuss with SWC Team in a sync, and discuss with our community in office hours. It makes sense to create a ticket for each sprint.

Related issue(s)

  • N/A, was cleaning out JIRA Jail RFCs and created this for my own sanity

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: [Aria Practices] N/A(https://www.w3.org/TR/wai-aria-practices/) N/A
  • I have added automated tests to cover my changes. N/A
  • I have included a well-written changeset if my change needs to be published. N/A
  • I have included updated documentation if my change required it. N/A

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features N/A
  • Automated tests cover all use cases and follow best practices for writing N/A
  • Validated on all supported browsers N/A
  • All VRTs are approved before the author can update Golden Hash N/A

Manual review test cases

  • Generate JIRA RFC tickets

    1. git checkout nikkmk/rfc-rules
    2. Ask cursor to generate tickets for an RFC of your choosing
    3. Verify that three RFC tickets are generated.
    4. Verify that the first ticket captures the unique details of writing your RFC
    5. Verify that the second ticket is similar to SWC-1387 but refers to your RFC instead
    6. Verify that the third ticket is similar to SWC-1388 but refers to your RFC instead

Device review

  • Did it pass in Desktop? N/A
  • Did it pass in (emulated) Mobile? N/A
  • Did it pass in (emulated) iPad? N/A

@nikkimk nikkimk added the Status: WIP PR is a work in progress or draft label Nov 25, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

⚠️ No Changeset found

Latest commit: f4fde45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5908

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Comment on lines +115 to +121
**Note:** For RFC tickets, generate three related tickets that must be completed sequentially:
1. RFC authoring and initial review
2. Internal discussion shepherding
3. External community discussion shepherding

#### First ticket: RFC authoring

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expands JIRA RFCs from a single ticket into three related tickets.

Comment on lines +132 to +138
Additional acceptance criteria for RFC tickets:
- RFC has been added to the [Decisions and RFCs wiki|https://wiki.corp.adobe.com/display/AdobeDesign/Decisions+and+RFCs]
- RFC link has been added to this ticket
- Announcement posted in {{spectrum-web-reviews}} Slack channel with internal comment deadline (minimum 1 week)
- Announcement posted in {{spectrum-web-engineering}} Slack channel with internal comment deadline (minimum 1 week)
- Internal discussion scheduled for SWC team sync after comment period

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work should happen in the first RFC to tee up the work for the second sprint/ticket.

(Add any other context, drafts, etc. if you have them)
```

#### Second ticket: Internal discussion shepherding
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of the process is the same regardless of RFC topic so we can get away with using a more explicit template that addresses what needs to happen to the RFC rather than what is in the RFC. I left placeholders for updating the name of the RFC that is shepherded as well as the link to the first ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: WIP PR is a work in progress or draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants