Skip to content

Conversation

@caseyisonit
Copy link
Contributor

@caseyisonit caseyisonit commented Nov 21, 2025

Description

  • Automated preview releases workflow needed to be updated with new version command now that we support two generations.
    • Runs with fix: fix( feat: feat( and !: in the squash and merge commit message when PRs are merged in to main
  • This also resolves an issue with the manual snapshot release script.
  • Removes an unused/unsupported workflow

Motivation and context

Let the people play with our code!

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Check preview release on NPM

    1. Go here
    2. See an 1.11.0 preview release that includes the github sha (was previous 1.6.1-preview)
  • Check snapshot release

    1. Checkout branch
    2. run node ./scripts/publish.js --tag snapshot enter your npm auth password
    3. Go here
    4. See new snapshot release
  • Check preview release post merge

    1. This workflow should run and successfully release a new preview because the squash and merge commit will include fix: in the message

@caseyisonit caseyisonit requested a review from a team as a code owner November 21, 2025 20:01
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: b45e197

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5906

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was flagged my adobe secruity because the action isnt approved and no longer runs. we are safe to remove this.

@caseyisonit caseyisonit changed the title chore: fix snapshot and preview releases fix: fix snapshot and preview releases Nov 21, 2025
@caseyisonit caseyisonit self-assigned this Nov 21, 2025
@caseyisonit caseyisonit added Status: Ready for review PR ready for review or re-review. Component: Tooling Issue or PR dealing with scripts, workflows, automation, etc. Component prefix is for Jira github_actions Pull requests that update GitHub Actions code labels Nov 21, 2025
Copy link
Member

@cdransf cdransf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Tooling Issue or PR dealing with scripts, workflows, automation, etc. Component prefix is for Jira github_actions Pull requests that update GitHub Actions code Status: Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants