-
Notifications
You must be signed in to change notification settings - Fork 227
ci: migrate docs + vrt websites from netlify to azure #5450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tachometer resultsCurrently, no packages are changed by this PR... |
26c248d
to
17651df
Compare
98e4da9
to
982025f
Compare
8f6eed3
to
ade5424
Compare
.circleci/config.yml
Outdated
# Set up Azure authentication | ||
echo 'export AZCOPY_AUTO_LOGIN_TYPE="SPN"' >> $BASH_ENV | ||
echo 'export AZCOPY_SPA_APPLICATION_ID="$AZURE_CLIENT_ID"' >> $BASH_ENV | ||
echo 'export AZCOPY_SPA_CLIENT_SECRET="$AZURE_CLIENT_SECRET"' >> $BASH_ENV | ||
echo 'export AZCOPY_TENANT_ID="$AZURE_TENANT_ID"' >> $BASH_ENV | ||
source $BASH_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? Looks like we’re already setting these in the node environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, single quotes here prevent variable expansion, so we’d just be writing the literal strings (e.g. $AZURE_CLIENT_ID
) into $BASH_ENV
.
5aa31cd
to
63ec4e7
Compare
63ec4e7
to
00799ac
Compare
2d5e02c
to
283d77e
Compare
283d77e
to
b42fd37
Compare
c095819
to
7ca2a12
Compare
63e10bc
to
b44ac75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVAL GRANTED! IN FACT, APPROVAL ASCENDED TO MYTHICAL STATUS!
Superb work @TarunAdobe ! This needs a celebration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TarunAdobe would you mind taking checking on the beta
URL? I tried hitting the URL in your original PR description (and then also tried putting the pr number in there and moving it around to different parts of the URL structure) and either I have the wrong URL or it didn't correctly deploy.
@pfulton Beta docs deploy only happens on main branch. so that link won't be accessible until this pr gets merged. |
Description
This PR migrates all preview deployments (documentation site, Storybook, and Visual Regression Tests) from Netlify to Azure Blob Storage for cost efficiency, and unified deployment strategy.
.
(JK, THE MAIN GOAL IS TO AVOID THE $20 BILL THAT JOSH IS PAYING OUT OF HIS OWN POCKET)
.
A quick overview of all the stuff I did in this PR
Key Changes:
Preview Deployments Now on Azure Blob Storage
All documentation, Storybook, and VRT previews for PRs and beta builds are now deployed to Azure Blob Storage.
All preview URLs posted on PRs and in documentation have been updated to point to Azure.
CI/CD Pipeline Modernization
CircleCI config (.circleci/config.yml):
GitHub Actions:
Documentation and User-Facing Changes
Dependency and Cleanup
Motivation and context
Operational Benefits:
Related issue(s)
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
featuresManual review test cases
Open a PR and verify that:
Ensure all CI jobs (CircleCI and GitHub Actions) succeed and the preview links are correct.
Check that all Netlify links/references are gone from docs and config.
Reviewers: See the posted PR comment for all preview links.
Device review