chore: script clean-up for packages and tokens[swc-808] #5419
Conversation
|
| @@ -50,7 +50,6 @@ | |||
| "lint:versions": "node ./scripts/lint-versions.js", | |||
| "new-package": "cd projects/templates && plop", | |||
| "postcustom-element-json": "node ./tasks/run-check-cem.js", | |||
| "postdocs:analyze": "node ./scripts/add-custom-properties.js --src=\"projects/documentation/custom-elements.json\"", | |||
There was a problem hiding this comment.
This is reading in spectrum-vars.json files from the packages in this repo and those files are legacy and no longer created or committed.
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
castastrophe
force-pushed
the
castastrophe/swc-808-disable-process-spectrum
branch
3 times, most recently
from
e0f9c5f to
5945a6d
Compare
| @@ -14,7 +14,7 @@ governing permissions and limitations under the License. | |||
|
|
|||
| import chokidar from 'chokidar'; | |||
| import debounce from 'debounce'; | |||
| import { processCSS } from './css-tools.js'; | |||
| import { processCSS } from './build-css.js'; | |||
There was a problem hiding this comment.
The css-tools file only had 1 task in it so I pulled that into build-css to simplify things a bit.
| } | ||
| } else { | ||
| console.warn(`check-cem.js not found for ${pkg.name}`); | ||
| async function checkCEM(pkg) { |
There was a problem hiding this comment.
I pulled this functionality directly into the run script here since it seemed like an unnecessary abstraction.
| 'ui-icons', | ||
| 'dist' | ||
| ) | ||
| const spectrumIconsPath = path.join( |
There was a problem hiding this comment.
path.resolve + path.join functions cause the drive to be listed twice in windows so I cleaned that up while I was here.
| @@ -60,8 +60,6 @@ | |||
| "case": "^1.6.1", | |||
| "cheerio": "^1.0.0-rc.2", | |||
| "fast-glob": "^3.2.12", | |||
| "fs": "^0.0.1-security", | |||
There was a problem hiding this comment.
fs and path are bundled with node and don't need to be pulled in explicitly (in fact it can be a risk).
| @@ -26,7 +26,6 @@ | |||
| "changeset-publish": "yarn prepublishOnly && yarn changeset version && yarn install && yarn lint:versions --fix && yarn update-version && yarn changeset publish --no-git-tag && yarn push-to-remote && yarn create-git-tag && yarn postpublish", | |||
| "update-version": "node ./tasks/update-version.js", | |||
| "chromatic": "chromatic --build-script-name storybook:build # note that --project-token must be set in your env variables", | |||
| "create-git-tag": "node --no-warnings tasks/create-git-tag.js", | |||
There was a problem hiding this comment.
I don't see this used or documented anywhere so is it safe to clean this up? We don't generate tags manually anyway now that we're using changesets.
castastrophe
force-pushed
the
castastrophe/swc-808-disable-process-spectrum
branch
from
5945a6d to
1045ca1
Compare
castastrophe
force-pushed
the
castastrophe/swc-808-disable-process-spectrum
branch
from
1045ca1 to
618cb83
Compare
Description
Related issue(s)
Motivation and context
How has this been tested?
Test case 1
Test case 2
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.