Skip to content

docs(overlay): a11y docs update #5409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

TarunAdobe
Copy link
Contributor

@TarunAdobe TarunAdobe commented Apr 29, 2025

Description

Improving the accessibility documentation of components.

Related issue(s)

  • SWC-390

Motivation and context

Documentation should provide more information and examples that demonstrate how to use the components accessibly.

How has this been tested?

Review overlay docs

  • Do the docs examples give enough context to test for accessibility?

  • Do the docs examples and text provide information on how to use the component accessibly?

  • If the component is to be used in the context of another component, do the examples include how that component is used accessibly in that context?

  • Are the docs headings logical and consistent across these components? You can use the WAVE browser extension's Structure tab to review heading structure.

  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Copy link

changeset-bot bot commented Apr 29, 2025

⚠️ No Changeset found

Latest commit: e3e76b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

Tachometer results

Currently, no packages are changed by this PR...

@TarunAdobe TarunAdobe force-pushed the ttomar/docs-overlay-a11y branch 3 times, most recently from d6f0e46 to 3cd6388 Compare April 29, 2025 09:20
#### Placement

When using the `placement` attribute of an `<overlay-trigger>` (`"top" |"top-start" | "top-end" | "bottom" | "bottom-start" | "bottom-end" | "right" | "right-start" | "right-end" | "left" | "left-start" | "left-end"`), you can suggest to the overlay in which direction relative to the trigger that the content should display. When there is adequate room for the content to display in the specified direction, it will do so. When adequate room is not available, the overlaid content will calculate the direction in which it has the most room to be displayed and use that direction.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want sp-tabs with examples of some of these placement options?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have examples of how to use the placement attribute in the docs so I wonder if we need to show all examples of all possible values for that attributes in this case. Thought it might be too redundant. But I am open to have my thoughts changed here

@TarunAdobe TarunAdobe force-pushed the ttomar/docs-overlay-a11y branch 3 times, most recently from ee09cc5 to 2faeeb2 Compare April 30, 2025 07:27
@TarunAdobe TarunAdobe marked this pull request as ready for review April 30, 2025 07:33
@TarunAdobe TarunAdobe requested a review from a team as a code owner April 30, 2025 07:33
@TarunAdobe TarunAdobe self-assigned this Apr 30, 2025
@TarunAdobe TarunAdobe force-pushed the ttomar/docs-overlay-a11y branch from 2faeeb2 to 499d562 Compare April 30, 2025 07:45
Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions for heading cases and wording but otherwise this is a great update with lots of improvements in it.

@TarunAdobe TarunAdobe force-pushed the ttomar/docs-overlay-a11y branch from 499d562 to 2311a0e Compare May 1, 2025 07:34
@@ -17,7 +17,7 @@
</div>
</div>

## Description
## Overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should use the alert-banner for our notices.

`;
```

<div class="spectrum-InLineAlert spectrum-InLineAlert--notice">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should use the alert-banner for our notices.

Copy link
Contributor

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit more feedback. Overall this is very impressive work and I appreciate the time you spent making this more understandable to both the consumers and the contributors.

@TarunAdobe TarunAdobe force-pushed the ttomar/docs-overlay-a11y branch from 2311a0e to e3e76b2 Compare May 5, 2025 10:25
@TarunAdobe TarunAdobe requested a review from nikkimk May 5, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants