-
Notifications
You must be signed in to change notification settings - Fork 222
[DO NOT MERGE] chore: system aware icons storybook in menu fast follows #5402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Note: This change has been made for the design to sign off on our Menu fast follows, but to make it more robust we would need to update our context Switcher(System Resolver) to also cascade the context of system down to slotted content also. Lit's context API doesn't allow this out of the box but we can update SystemResolverController to extend this capability. Let this PR be open for now, I will make the necessary changes on a high level which would need some deeper dive. |
Description
This PR introduces a
SystemAwareMenu
class that demonstrates that the component only overrides the update lifecycle method to re-render itself and cascade the system context to its children. This minimalist approach allows the system context to flow through the component tree and ensures all descendant components can respond to system changes.This serves as a container component that can wrap any menu or other component, providing system resolution capabilities through Lit's slot mechanism. This approach allows components to automatically adapt to system context changes (e.g., Spectrum 1, Spectrum 2, Express) without requiring direct modification of each individual component.
Features
TODO
How has this been tested?
Test case 1
Test case 2
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.