fix(tooltip): restore negative and informative semantic variants #3641
+62
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dfcbd61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cdransf
force-pushed
the
cdransf/s2-tooltip-semantic-variants
branch
from
f6a7e85 to
c215a47
Compare
cdransf
added
size-3 M
cdransf
requested review from
marissahuysentruyt,
castastrophe and
rise-erpelding
File metricsSummaryTotal size: 1.37 MB*
tooltip
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-3641--spectrum-css.netlify.app |
cdransf
force-pushed
the
cdransf/s2-tooltip-semantic-variants
branch
from
c215a47 to
d961f08
Compare
marissahuysentruyt
requested changes
Apr 1, 2025
marissahuysentruyt
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
I think this looks great!
Just a note that the commit when we squash this down, should probably be a fix, since we're changing CSS, but not introducing a breaking change. Cassondra mentioned once that if there's CSS changes, we should label our commits as fix or feat.
| @@ -14,8 +14,6 @@ | |||
| @import "@spectrum-css/commons/overlay.css"; | |||
|
|
|||
| .spectrum-Tooltip { | |||
| --spectrum-tooltip-backgound-color-default-neutral: var(--spectrum-neutral-subdued-background-color-default); | |||
cdransf
force-pushed
the
cdransf/s2-tooltip-semantic-variants
branch
2 times, most recently
from
616a05a to
cfa34ed
Compare
cdransf
changed the title
cdransf
force-pushed
the
cdransf/s2-tooltip-semantic-variants
branch
from
cfa34ed to
dfcbd61
Compare
castastrophe
approved these changes
Apr 2, 2025
| "@spectrum-css/tooltip": minor | ||
| --- | ||
|
|
||
| #### S2: restore negative and informative semantic variants |
There was a problem hiding this comment.
Nice use of the heading levels 🥳
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This restores the negative and informative tooltip semantic variant styles, story controls and test cases. Icons have been removed for all variants as they are not present in the specifications provided by design.
Restored mods
--mod-tooltip-background-color-informative--mod-tooltip-background-color-negative"Validation steps
Defaultstory for the tooltip component.Screenshots
To-do list