Skip to content

refactor(stepper): standardize selectors and passthroughs usage #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+134 −12,937
Draft

refactor(stepper): standardize selectors and passthroughs usage #3558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94657cb
chore(stepper): add focused+hovered test
marissahuysentruyt Feb 13, 2025
774f391
fix(stepper): fix focus and focus hover states
marissahuysentruyt Feb 14, 2025
3206b0b
chore(stepper): create changeset
marissahuysentruyt Feb 26, 2025
876ee12
chore: update tokens/yarn.lock after rebase
marissahuysentruyt Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changeset/selfish-ravens-drive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
"@spectrum-css/stepper": minor
---

Previously, stepper has some inconsistencies in its hover interactions, particularly when the stepper was in a different state, like focus or keyboardFocus. The changes here should ensure any combination of hovering over a nested stepper sub-components triggers the correct border color changes to all subcomponents. As an example, hovering over the stepper buttons should trigger a border color change in the stepper buttons, AS WELL AS trigger the border color on the stepper textfield.

New mods:
`--mod-stepper-border-color-disabled`

Removed mods:
`--mod-stepper-buttons-border-color`
`--mod-stepper-buttons-border-color-focus`
`--mod-stepper-buttons-border-color-focus-hover`
`--mod-stepper-buttons-border-color-hover`
`--mod-stepper-buttons-border-color-keyboard-focus`
59 changes: 35 additions & 24 deletions components/stepper/dist/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,41 +4,60 @@
".spectrum-Stepper",
".spectrum-Stepper--quiet",
".spectrum-Stepper--quiet.hide-stepper .spectrum-Stepper-input",
".spectrum-Stepper--quiet.is-disabled",
".spectrum-Stepper--quiet.is-keyboardFocused:not(.is-disabled)",
".spectrum-Stepper--quiet:after",
".spectrum-Stepper--quiet:not(.is-disabled):focus-visible",
".spectrum-Stepper-button",
".spectrum-Stepper-buttons",
".spectrum-Stepper-input",
".spectrum-Stepper.hide-stepper .spectrum-Stepper-input",
".spectrum-Stepper.is-disabled",
".spectrum-Stepper.is-focused",
".spectrum-Stepper.is-focused.is-hover",
".spectrum-Stepper.is-focused:hover",
".spectrum-Stepper.is-focused:not(.is-disabled)",
".spectrum-Stepper.is-focused:not(.is-disabled):hover",
".spectrum-Stepper.is-hover:focus",
".spectrum-Stepper.is-hover:focus-visible",
".spectrum-Stepper.is-hover:not(.is-disabled)",
".spectrum-Stepper.is-invalid",
".spectrum-Stepper.is-invalid.is-focused",
".spectrum-Stepper.is-invalid.is-focused.is-hover",
".spectrum-Stepper.is-invalid.is-focused:hover",
".spectrum-Stepper.is-invalid.is-hover:focus",
".spectrum-Stepper.is-invalid.is-keyboardFocused",
".spectrum-Stepper.is-invalid.is-keyboardFocused:hover",
".spectrum-Stepper.is-invalid:focus",
".spectrum-Stepper.is-invalid:focus-visible",
".spectrum-Stepper.is-invalid:focus-visible:hover",
".spectrum-Stepper.is-invalid:focus:hover",
".spectrum-Stepper.is-invalid:hover",
".spectrum-Stepper.is-keyboardFocused",
".spectrum-Stepper.is-keyboardFocused.is-hover",
".spectrum-Stepper.is-keyboardFocused:hover",
".spectrum-Stepper.is-keyboardFocused:not(.is-disabled)",
".spectrum-Stepper.spectrum-Stepper--quiet",
".spectrum-Stepper.spectrum-Stepper--quiet.is-focused:not(.is-disabled)",
".spectrum-Stepper.spectrum-Stepper--quiet.is-focused:not(.is-disabled):hover",
".spectrum-Stepper.spectrum-Stepper--quiet.is-disabled",
".spectrum-Stepper.spectrum-Stepper--quiet.is-focused",
".spectrum-Stepper.spectrum-Stepper--quiet.is-focused:hover",
".spectrum-Stepper.spectrum-Stepper--quiet.is-invalid",
".spectrum-Stepper.spectrum-Stepper--quiet.is-keyboardFocused",
".spectrum-Stepper.spectrum-Stepper--quiet.is-keyboardFocused:hover",
".spectrum-Stepper.spectrum-Stepper--quiet.is-keyboardFocused:not(.is-disabled)",
".spectrum-Stepper.spectrum-Stepper--quiet.is-keyboardFocused:not(.is-disabled):hover",
".spectrum-Stepper.spectrum-Stepper--quiet:not(.is-disabled):focus",
".spectrum-Stepper.spectrum-Stepper--quiet:not(.is-disabled):focus:hover",
".spectrum-Stepper.spectrum-Stepper--quiet:focus",
".spectrum-Stepper.spectrum-Stepper--quiet:focus-visible",
".spectrum-Stepper.spectrum-Stepper--quiet:focus-visible:hover",
".spectrum-Stepper.spectrum-Stepper--quiet:focus:hover",
".spectrum-Stepper.spectrum-Stepper--quiet:not(.is-disabled):hover",
".spectrum-Stepper.spectrum-Stepper--sizeL",
".spectrum-Stepper.spectrum-Stepper--sizeM",
".spectrum-Stepper.spectrum-Stepper--sizeS",
".spectrum-Stepper.spectrum-Stepper--sizeXL",
".spectrum-Stepper:before",
".spectrum-Stepper:hover:not(.is-invalid, .is-disabled, .is-focused)",
".spectrum-Stepper:not(.is-disabled) .is-focused",
".spectrum-Stepper:not(.is-disabled) .is-focused:hover",
".spectrum-Stepper:focus",
".spectrum-Stepper:focus-visible",
".spectrum-Stepper:focus-visible:hover",
".spectrum-Stepper:focus:hover",
".spectrum-Stepper:not(.is-disabled):focus",
".spectrum-Stepper:not(.is-disabled):focus-visible",
".spectrum-Stepper:not(.is-disabled):focus:hover",
Expand All @@ -48,6 +67,7 @@
"modifiers": [
"--mod-stepper-animation-duration",
"--mod-stepper-border-color",
"--mod-stepper-border-color-disabled",
"--mod-stepper-border-color-focus",
"--mod-stepper-border-color-focus-hover",
"--mod-stepper-border-color-focus-hover-invalid",
Expand All @@ -63,11 +83,6 @@
"--mod-stepper-button-width",
"--mod-stepper-button-width-quiet",
"--mod-stepper-buttons-background-color",
"--mod-stepper-buttons-border-color",
"--mod-stepper-buttons-border-color-focus",
"--mod-stepper-buttons-border-color-focus-hover",
"--mod-stepper-buttons-border-color-hover",
"--mod-stepper-buttons-border-color-keyboard-focus",
"--mod-stepper-buttons-border-style",
"--mod-stepper-buttons-border-width",
"--mod-stepper-focus-indicator-color",
Expand All @@ -88,6 +103,7 @@
"--spectrum-stepper-border-color-focus-hover-invalid",
"--spectrum-stepper-border-color-focus-invalid",
"--spectrum-stepper-border-color-hover",
"--spectrum-stepper-border-color-hover-invalid",
"--spectrum-stepper-border-color-invalid",
"--spectrum-stepper-border-color-keyboard-focus",
"--spectrum-stepper-border-color-keyboard-focus-invalid",
Expand All @@ -99,11 +115,6 @@
"--spectrum-stepper-button-width",
"--spectrum-stepper-buttons-background-color",
"--spectrum-stepper-buttons-background-color-disabled",
"--spectrum-stepper-buttons-border-color",
"--spectrum-stepper-buttons-border-color-focus",
"--spectrum-stepper-buttons-border-color-focus-hover",
"--spectrum-stepper-buttons-border-color-hover",
"--spectrum-stepper-buttons-border-color-keyboard-focus",
"--spectrum-stepper-buttons-border-style",
"--spectrum-stepper-buttons-border-width",
"--spectrum-stepper-focus-indicator-color",
Expand All @@ -121,7 +132,6 @@
"--spectrum-component-height-300",
"--spectrum-component-height-75",
"--spectrum-corner-radius-100",
"--spectrum-disabled-border-color",
"--spectrum-focus-indicator-color",
"--spectrum-focus-indicator-gap",
"--spectrum-focus-indicator-thickness",
Expand Down Expand Up @@ -151,6 +161,7 @@
"--system-stepper-border-color-focus-hover-invalid",
"--system-stepper-border-color-focus-invalid",
"--system-stepper-border-color-hover",
"--system-stepper-border-color-hover-invalid",
"--system-stepper-border-color-invalid",
"--system-stepper-border-color-keyboard-focus",
"--system-stepper-border-color-keyboard-focus-invalid",
Expand All @@ -159,10 +170,6 @@
"--system-stepper-button-border-width-disabled",
"--system-stepper-buttons-background-color",
"--system-stepper-buttons-background-color-disabled",
"--system-stepper-buttons-border-color",
"--system-stepper-buttons-border-color-focus",
"--system-stepper-buttons-border-color-hover",
"--system-stepper-buttons-border-color-keyboard-focus",
"--system-stepper-buttons-border-style",
"--system-stepper-buttons-border-width",
"--system-stepper-quiet-button-edge-to-fill",
Expand All @@ -184,7 +191,11 @@
"--mod-textfield-background-color",
"--mod-textfield-border-color",
"--mod-textfield-border-color-disabled",
"--mod-textfield-border-color-focus",
"--mod-textfield-border-color-hover",
"--mod-textfield-border-color-invalid-focus",
"--mod-textfield-border-color-invalid-hover",
"--mod-textfield-border-color-keyboard-focus",
"--mod-textfield-border-width",
"--mod-textfield-focus-indicator-color",
"--mod-textfield-focus-indicator-width",
Expand Down
Loading
Loading