device wise metrics #683
Open
device wise metrics #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forms: device wise segregation in metrics
nit23uec
reviewed
Apr 10, 2025
| @@ -54,7 +55,13 @@ function aggregateFormVitalsByDevice(formVitalsCollection) { | |||
| totals.formengagement = calculateSums(formengagement, totals.formengagement); | |||
| totals.pageview = calculateSums(pageview, totals.pageview); | |||
| totals.formsubmit = calculateSums(formsubmit, totals.formsubmit); | |||
|
|
|||
| // Traffic Acquisition is not aggregated by device type | |||
| totals.trafficacquisition = { | |||
There was a problem hiding this comment.
totals.trafficacquisition = { ...trafficacquisition }
nit23uec
reviewed
Apr 10, 2025
| formEngagement, | ||
| formSubmit, | ||
| pageViews: { | ||
| total: pageViews, |
There was a problem hiding this comment.
I'd suggest to simplify it to:
urls.push({
url,
...metrics
});
There was a problem hiding this comment.
we can cleanup all the existing code then
nit23uec
reviewed
Apr 10, 2025
| let formViews = metrics.formview.total; | ||
| let mobileFormViews = metrics.formview.mobile; | ||
| let desktopFormViews = metrics.formview.desktop; | ||
| if (!formViews) { |
There was a problem hiding this comment.
lets skip the fallback now as we have improved RUM to capture formviews.
nit23uec
reviewed
Apr 10, 2025
| pageViews: deviceData.pageview.total, | ||
| formViews: deviceData.formview.total, | ||
| formEngagement: deviceData.formengagement.total, | ||
| pageViews: deviceData.pageview, |
There was a problem hiding this comment.
same here too:
urls.push({
url,
...metrics
});
| // Default to pageViews if formViews are not available | ||
| const formViews = metrics.formview.total || pageViews; | ||
| let formViews = metrics.formview.total; |
There was a problem hiding this comment.
please check if formViews = 0
hasLowerConversionRate this will do division by 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forms: device wise segregation in metrics
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!