feat: Low form views auto detect #814

barshat7 · 2025-04-17T05:51:24Z

Please ensure your pull request adheres to the following guidelines:

make sure to link the related issues in this description
when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

src/forms-opportunities/utils.js

src/forms-opportunities/oppty-handlers/low-form-views-handler.js

github-actions · 2025-04-21T05:44:32Z

This PR will trigger a minor release when merged.

src/forms-opportunities/constants.js

nit23uec · 2025-04-22T05:43:15Z

src/forms-opportunities/handler.js

@@ -19,6 +19,7 @@ import { generateOpptyData } from './utils.js';
 import { getScrapedDataForSiteId } from '../support/utils.js';
 import createLowConversionOpportunities from './oppty-handlers/low-conversion-handler.js';
 import createLowNavigationOpportunities from './oppty-handlers/low-navigation-handler.js';
+import createLowFormViewsOpportunities from './oppty-handlers/low-form-views-handler.js';


low-views-handler.js

src/forms-opportunities/oppty-handlers/low-form-views-handler.js

nit23uec · 2025-04-22T05:44:12Z

src/forms-opportunities/oppty-handlers/low-form-views-handler.js

+        runbook: 'https://adobe.sharepoint.com/:w:/s/AEM_Forms/EeYKNa4HQkRAleWXjC5YZbMBMhveB08F1yTTUQSrP97Eow?e=cZdsnA',
+        type: FORM_OPPORTUNITY_TYPES.LOW_FORM_VIEWS,
+        origin: 'AUTOMATION',
+        title: 'Form page has high views but the form has low views',


title: 'Form has low views'

src/forms-opportunities/oppty-handlers/low-form-views-handler.js

src/forms-opportunities/utils.js

test/fixtures/forms/high-form-views-low-conversions.js

src/forms-opportunities/handler.js

nit23uec

inline comments.

src/forms-opportunities/oppty-handlers/low-form-views-handler.js

src/forms-opportunities/oppty-handlers/low-views-handler.js

src/forms-opportunities/handler.js

src/forms-opportunities/oppty-handlers/low-views-handler.js

feat: forms - high page views, low form views opportunity feat: forms - high page views, low form views opportunity - review comments feat: forms - high page views, low form views opportunity - review comments feat: forms - high page views, low form views opportunity feat: forms - high page views, low form views opportunity - refactoring feat: low form views: avoid repetition of same form over multiple opportunities feat: low form views: updated guidance and descriptions

…urce to exclude duplicate opportunities

nit23uec · 2025-04-23T12:11:03Z

src/forms-opportunities/oppty-handlers/low-views-handler.js

+  log.debug(`forms opportunities high-page-views-low-form-views: ${JSON.stringify(formOpportunities, null, 2)}`);
+
+  const filteredOpportunities = filterForms(formOpportunities, scrapedData, log, excludeForms);
+  filteredOpportunities.forEach((oppty) => excludeForms.add(oppty.form + oppty.formsource));


can we update this excludeForms set in filterForms method itself?

# [1.79.0](v1.78.1...v1.79.0) (2025-04-24) ### Features * Low form views auto detect ([#814](#814)) ([e282cdb](e282cdb))

solaris007 · 2025-04-24T03:00:48Z

🎉 This PR is included in version 1.79.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

* main: chore(release): 1.79.2 [skip ci] fix: remove cwv data from forms audit (#817) chore(release): 1.79.1 [skip ci] fix(deps): update dependency @adobe/spacecat-shared-data-access to v2.16.0 (#816) chore(release): 1.79.0 [skip ci] feat: Low form views auto detect (#814)

barshat7 changed the title ~~Low form views auto detect~~ feat: Low form views auto detect Apr 17, 2025

05rahulsingh reviewed Apr 17, 2025

View reviewed changes

src/forms-opportunities/utils.js Outdated Show resolved Hide resolved

05rahulsingh reviewed Apr 17, 2025

View reviewed changes

src/forms-opportunities/oppty-handlers/low-form-views-handler.js Outdated Show resolved Hide resolved

05rahulsingh reviewed Apr 17, 2025

View reviewed changes

src/forms-opportunities/oppty-handlers/low-form-views-handler.js Outdated Show resolved Hide resolved